2021-06-14 06:06:39

by Christoph Hellwig

[permalink] [raw]
Subject: [PATCH] null_blk: remove an unused variable assignment in null_add_dev

Fix up the recent blk_alloc_disk conversion.

Signed-off-by: Christoph Hellwig <[email protected]>
---
drivers/block/null_blk/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 3b320b005aa8..d734e9ee1546 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1849,7 +1849,6 @@ static int null_add_dev(struct nullb_device *dev)
if (!null_setup_fault())
goto out_cleanup_tags;

- rv = -ENOMEM;
nullb->tag_set->timeout = 5 * HZ;
nullb->disk = blk_mq_alloc_disk(nullb->tag_set, nullb);
if (IS_ERR(nullb->disk)) {
--
2.30.2


2021-06-15 21:58:54

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] null_blk: remove an unused variable assignment in null_add_dev

On 6/14/21 12:02 AM, Christoph Hellwig wrote:
> Fix up the recent blk_alloc_disk conversion.

Applied, thanks.

--
Jens Axboe