2020-12-02 23:44:48

by Bhaumik Bhatt

Subject: [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state

If a channel was explicitly stopped but not reset, allow it to
move to a disabled state so the channel context can be cleaned
up. As the channel remained in a stopped state, its context was
not reset and cleared, which needs to be done if a client driver
module is unloaded or a device crash occurs.

Signed-off-by: Bhaumik Bhatt <[email protected]>
---
drivers/bus/mhi/core/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index f0697f4..e7b9a90 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -1288,7 +1288,8 @@ static int mhi_driver_remove(struct device *dev)

mutex_lock(&mhi_chan->mutex);

- if (ch_state[dir] == MHI_CH_STATE_ENABLED &&
+ if ((ch_state[dir] == MHI_CH_STATE_ENABLED ||
+ ch_state[dir] == MHI_CH_STATE_STOP) &&
!mhi_chan->offload_ch)
mhi_deinit_chan_ctxt(mhi_cntrl, mhi_chan);

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-12-03 00:22:20

by Hemant Kumar

Subject: Re: [PATCH v3 2/7] bus: mhi: core: Allow channel to be disabled from stopped state

On 12/2/20 3:40 PM, Bhaumik Bhatt wrote:
> If a channel was explicitly stopped but not reset, allow it to
> move to a disabled state so the channel context can be cleaned
> up. As the channel remained in a stopped state, its context was
> not reset and cleared, which needs to be done if a client driver
> module is unloaded or a device crash occurs.
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>
> ---

Reviewed-by: Hemant Kumar <[email protected]>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project