2023-11-20 02:56:09

by Jerry Shih

[permalink] [raw]
Subject: Re: [PATCH 10/12] RISC-V: crypto: add Zvksed accelerated SM4 implementation

On Nov 2, 2023, at 13:58, Eric Biggers <[email protected]> wrote:
> On Thu, Oct 26, 2023 at 02:36:42AM +0800, Jerry Shih wrote:
>> +struct crypto_alg riscv64_sm4_zvksed_alg = {
>> + .cra_name = "sm4",
>> + .cra_driver_name = "sm4-riscv64-zvkb-zvksed",
>> + .cra_module = THIS_MODULE,
>> + .cra_priority = 300,
>> + .cra_flags = CRYPTO_ALG_TYPE_CIPHER,
>> + .cra_blocksize = SM4_BLOCK_SIZE,
>> + .cra_ctxsize = sizeof(struct sm4_ctx),
>> + .cra_cipher = {
>> + .cia_min_keysize = SM4_KEY_SIZE,
>> + .cia_max_keysize = SM4_KEY_SIZE,
>> + .cia_setkey = riscv64_sm4_setkey_zvksed,
>> + .cia_encrypt = riscv64_sm4_encrypt_zvksed,
>> + .cia_decrypt = riscv64_sm4_decrypt_zvksed,
>> + },
>> +};
>
> This should be 'static'.
>
> - Eric

Thx.
Fixed.


-Jerry