2020-08-08 08:46:12

by Miaohe Lin

Subject: [PATCH] io_uring: Convert to use the fallthrough macro

From: Miaohe Lin <[email protected]>

Convert the uses of fallthrough comments to fallthrough macro.

Signed-off-by: Hongxiang Lou <[email protected]>
Signed-off-by: Miaohe Lin <[email protected]>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 2a3af95be4ca..77e932c25312 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2516,7 +2516,7 @@ static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret)
* IO with EINTR.
*/
ret = -EINTR;
- /* fall through */
+ fallthrough;
default:
kiocb->ki_complete(kiocb, ret, 0);
}
--
2.19.1

2020-08-22 08:12:45

by Miaohe Lin

Subject: Re: [PATCH] io_uring: Convert to use the fallthrough macro

Friendly ping :)

>From: Miaohe Lin <[email protected]>
>
>Convert the uses of fallthrough comments to fallthrough macro.
>
>Signed-off-by: Hongxiang Lou <[email protected]>
>Signed-off-by: Miaohe Lin <[email protected]>
>---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/io_uring.c b/fs/io_uring.c index 2a3af95be4ca..77e932c25312 100644
>--- a/fs/io_uring.c
>+++ b/fs/io_uring.c
>@@ -2516,7 +2516,7 @@ static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret)
> * IO with EINTR.
> */
> ret = -EINTR;
>- /* fall through */
>+ fallthrough;
> default:
> kiocb->ki_complete(kiocb, ret, 0);
> }
>--
>2.19.1
>

2020-08-22 15:52:51

by Jens Axboe

Subject: Re: [PATCH] io_uring: Convert to use the fallthrough macro

On 8/22/20 2:11 AM, linmiaohe wrote:
> Friendly ping :)

Huh, I thought I had applied this. I'll queue it up for 5.10, thanks.

--
Jens Axboe