From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 20:24:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in mtd_concat_create()
Improve a size determination in concat_erase()
drivers/mtd/mtdconcat.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
--
2.15.1
From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 19:55:10 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mtd/mtdconcat.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index 60bf53df5454..f1a60c55a126 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -668,12 +668,9 @@ struct mtd_info *mtd_concat_create(struct mtd_info *subdev[], /* subdevices to c
/* allocate the device structure */
size = SIZEOF_STRUCT_MTD_CONCAT(num_devs);
concat = kzalloc(size, GFP_KERNEL);
- if (!concat) {
- printk
- ("memory allocation error while creating concatenated device \"%s\"\n",
- name);
+ if (!concat)
return NULL;
- }
+
concat->subdev = (struct mtd_info **) (concat + 1);
/*
--
2.15.1
From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 20:00:27 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mtd/mtdconcat.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index f1a60c55a126..67d39e562c0f 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -428,8 +428,7 @@ static int concat_erase(struct mtd_info *mtd, struct erase_info *instr)
}
/* make a local copy of instr to avoid modifying the caller's struct */
- erase = kmalloc(sizeof (struct erase_info), GFP_KERNEL);
-
+ erase = kmalloc(sizeof(*erase), GFP_KERNEL);
if (!erase)
return -ENOMEM;
--
2.15.1