2024-02-22 06:13:43

by Dan Carpenter

Subject: [PATCH] firmware/sysfb: fix an error code in sysfb_init()

This error path accidentally returns success when it should preserve the
error code from sysfb_parent_dev().

Fixes: 4e754597d603 ("firmware/sysfb: Create firmware device only for enabled PCI devices")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/firmware/sysfb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c
index a6b48703dc9e..880ffcb50088 100644
--- a/drivers/firmware/sysfb.c
+++ b/drivers/firmware/sysfb.c
@@ -127,8 +127,10 @@ static __init int sysfb_init(void)
sysfb_apply_efi_quirks();

parent = sysfb_parent_dev(si);
- if (IS_ERR(parent))
+ if (IS_ERR(parent)) {
+ ret = PTR_ERR(parent);
goto unlock_mutex;
+ }

/* try to create a simple-framebuffer device */
compatible = sysfb_parse_mode(si, &mode);
--
2.43.0

2024-02-22 08:11:17

by Thomas Zimmermann

Subject: Re: [PATCH] firmware/sysfb: fix an error code in sysfb_init()

Am 22.02.24 um 07:13 schrieb Dan Carpenter:
> This error path accidentally returns success when it should preserve the
> error code from sysfb_parent_dev().

Thanks! I'll land the patch via drm-misc.

>
> Fixes: 4e754597d603 ("firmware/sysfb: Create firmware device only for enabled PCI devices")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> drivers/firmware/sysfb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c
> index a6b48703dc9e..880ffcb50088 100644
> --- a/drivers/firmware/sysfb.c
> +++ b/drivers/firmware/sysfb.c
> @@ -127,8 +127,10 @@ static __init int sysfb_init(void)
> sysfb_apply_efi_quirks();
>
> parent = sysfb_parent_dev(si);
> - if (IS_ERR(parent))
> + if (IS_ERR(parent)) {
> + ret = PTR_ERR(parent);
> goto unlock_mutex;
> + }
>
> /* try to create a simple-framebuffer device */
> compatible = sysfb_parse_mode(si, &mode);

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)