2015-04-07 07:53:20

by Gilad Broner

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] scsi: ufs: add support to allow non standard behaviours (quirks)


> Some implementation of UFS host controller HW might have some non-standard
> behaviours (quirks) when compared to behaviour specified by UFSHCI
> specification. This patch add support to allow specifying all such quirks
> to standard UFS host controller driver so standard driver takes them into
> account.
>
> In this change a UFSHCD_QUIRK_DELAY_BEFORE_DME_CMDS is introduced,
> where a minimum delay of 1ms is required before DME commands for
> stability purposes.
>
> Signed-off-by: Yaniv Gardi <[email protected]>
>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 22 +++++++++++++++++-----
> drivers/scsi/ufs/ufs-qcom.h | 18 ++++++++++++++++++
> drivers/scsi/ufs/ufshcd.c | 35 +++++++++++++++++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.h | 9 +++++++++
> 4 files changed, 79 insertions(+), 5 deletions(-)
>

Reviewed-by: Gilad Broner <[email protected]>

--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project