From: Paul Bolle <[email protected]>
A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related
symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has
always evaluated to false. Remove it.
Signed-off-by: Paul Bolle <[email protected]>
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Still valid after 8 years...
Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220
---
arch/arm/boot/compressed/head.S | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
index bf79f2f78d232306..9f406e9c0ea6f74b 100644
--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -67,11 +67,7 @@
#if defined(CONFIG_ARCH_SA1100)
.macro loadsp, rb, tmp1, tmp2
mov \rb, #0x80000000 @ physical base address
-#ifdef CONFIG_DEBUG_LL_SER3
- add \rb, \rb, #0x00050000 @ Ser3
-#else
add \rb, \rb, #0x00010000 @ Ser1
-#endif
.endm
#else
.macro loadsp, rb, tmp1, tmp2
--
2.25.1
On Wed, Sep 28, 2022 at 12:14 PM Geert Uytterhoeven
<[email protected]> wrote:
> From: Paul Bolle <[email protected]>
>
> A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related
> symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has
> always evaluated to false. Remove it.
>
> Signed-off-by: Paul Bolle <[email protected]>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Still valid after 8 years...
> Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220
:D
Reviewed-by: Linus Walleij <[email protected]>
Please put this into Russell's patch tracker.
Yours,
Linus Walleij
Hi Linus,
On Tue, Oct 4, 2022 at 9:44 AM Linus Walleij <[email protected]> wrote:
> On Wed, Sep 28, 2022 at 12:14 PM Geert Uytterhoeven
> <[email protected]> wrote:
> > From: Paul Bolle <[email protected]>
> >
> > A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related
> > symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has
> > always evaluated to false. Remove it.
> >
> > Signed-off-by: Paul Bolle <[email protected]>
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > Still valid after 8 years...
> > Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220
>
> :D
>
> Reviewed-by: Linus Walleij <[email protected]>
Thanks!
> Please put this into Russell's patch tracker.
Arnd took it into soc/for-next as commit 4413794917ba3ff4 ("ARM:
remove check for CONFIG_DEBUG_LL_SER3").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Geert Uytterhoeven schreef op di 04-10-2022 om 09:48 [+0200]:
> Arnd took it into soc/for-next as commit 4413794917ba3ff4 ("ARM:
> remove check for CONFIG_DEBUG_LL_SER3").
This is really nice!
One of the few of the commits that I'm actually proud of is e5a7286b5f1b
("x86, boot: Remove ancient, unconditionally #ifdef'd out dead code"). That
commit removed code that was dead for sixteen years. This patch - if it
crosses the finish line - will remove code that's been dead for twenty years.
Yay Geert! I'm so glad this patch was hibernated for eight years, promoting
code dead for twelve years to code dead for twenty years.
But there must be even older dead code in the tree. So let's make this a
contest! I'll ship some Dutch treats to the author of a patch that removes
code that has been dead for the longest time when committed by Linus no later
than December 5th, 2022. (Wikipedia can explain this odd deadline.)
Grave diggers: on your mark!
Paul Bolle