2022-03-02 09:38:26

by Shunzhou Jiang

[permalink] [raw]
Subject: [PATCH V5 0/2] Power: meson-s4: add s4 power domain driver

This patchset adds Power controller driver support for Meson-S4 SoC
Likes Meson-A1, the power domains register only can access in secure world

Shunzhou Jiang (2):
dt-bindings: power: add Amlogic s4 power domains bindings
soc: s4: Add support for power domains controller

.../power/amlogic,meson-sec-pwrc.yaml | 3 ++-
drivers/soc/amlogic/meson-secure-pwrc.c | 22 +++++++++++++++++++
include/dt-bindings/power/meson-s4-power.h | 19 ++++++++++++++++
3 files changed, 43 insertions(+), 1 deletion(-)
create mode 100644 include/dt-bindings/power/meson-s4-power.h


base-commit: 3448a018ded03ccd4093d6675f4a39eb2d1a18ef
--
2.34.1


2022-03-02 11:30:07

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH V5 0/2] Power: meson-s4: add s4 power domain driver

Hi,

On 02/03/2022 04:17, [email protected] wrote:
> Hi,
> OK, thanks your reply
> I will check this issue

Another x8 set of mails arrived on the mailing-list from your side, please fix the problem.

Neil

> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Shunzhou Jiang
> SW Department
>
> *From:* Neil Armstrong <mailto:[email protected]>
> *Date:* 2022-03-01 16:39
> *To:* Shunzhou Jiang <mailto:[email protected]>
> *CC:* linux-arm-kernel <mailto:[email protected]>; linux-amlogic <mailto:[email protected]>; linux-kernel <mailto:[email protected]>; devicetree <mailto:[email protected]>; khilman <mailto:[email protected]>; jbrunet <mailto:[email protected]>; martin.blumenstingl <mailto:[email protected]>; jianxin.pan <mailto:[email protected]>
> *Subject:* Re: [PATCH V5 0/2] Power: meson-s4: add s4 power domain driver
> [ EXTERNAL EMAIL ]
> Hi,
> On 01/03/2022 02:58, Shunzhou Jiang wrote:
> > This patchset adds Power controller driver support for Meson-S4 SoC
> > Likes Meson-A1, the power domains register only can access in secure world
> >
> > Shunzhou Jiang (2):
> >    dt-bindings: power: add Amlogic s4 power domains bindings
> >    soc: s4: Add support for power domains controller
> >
> >   .../power/amlogic,meson-sec-pwrc.yaml         |  3 ++-
> >   drivers/soc/amlogic/meson-secure-pwrc.c       | 22 +++++++++++++++++++
> >   include/dt-bindings/power/meson-s4-power.h    | 19 ++++++++++++++++
> >   3 files changed, 43 insertions(+), 1 deletion(-)
> >   create mode 100644 include/dt-bindings/power/meson-s4-power.h
> >
> >
> > base-commit: 3448a018ded03ccd4093d6675f4a39eb2d1a18ef
> I think you have an issue with your mail setup, you sent 5 times the same "[PATCH V5 0/2] Power: meson-s4: add s4 power domain driver" patchset.
> Please fix it and maker it doesn't happen again.
> Thanks,
> Neil
>

2022-03-02 21:36:20

by Shunzhou Jiang

[permalink] [raw]
Subject: [PATCH V5 1/2] dt-bindings: power: add Amlogic s4 power domains bindings

Add the bindings for the Amlogic Secure power domains, controlling the
secure power domains.

The bindings targets the Amlogic s4, in which the power domains registers
are in secure world.

Signed-off-by: Shunzhou Jiang <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>
---
V1->V2: fix spelling error, patchset use cover-letter
V2->V3: add power domain always on reason
V3->V4: clear vpu and usb power domaon always on
V4->V5: add reviewed owner in patchset
---
.../power/amlogic,meson-sec-pwrc.yaml | 3 ++-
include/dt-bindings/power/meson-s4-power.h | 19 +++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 include/dt-bindings/power/meson-s4-power.h

diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index 5dae04d2936c..7657721a4e96 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -12,13 +12,14 @@ maintainers:
- Jianxin Pan <[email protected]>

description: |+
- Secure Power Domains used in Meson A1/C1 SoCs, and should be the child node
+ Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node
of secure-monitor.

properties:
compatible:
enum:
- amlogic,meson-a1-pwrc
+ - amlogic,meson-s4-pwrc

"#power-domain-cells":
const: 1
diff --git a/include/dt-bindings/power/meson-s4-power.h b/include/dt-bindings/power/meson-s4-power.h
new file mode 100644
index 000000000000..462dd2cb938b
--- /dev/null
+++ b/include/dt-bindings/power/meson-s4-power.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
+/*
+ * Copyright (c) 2021 Amlogic, Inc.
+ * Author: Shunzhou Jiang <[email protected]>
+ */
+
+#ifndef _DT_BINDINGS_MESON_S4_POWER_H
+#define _DT_BINDINGS_MESON_S4_POWER_H
+
+#define PWRC_S4_DOS_HEVC_ID 0
+#define PWRC_S4_DOS_VDEC_ID 1
+#define PWRC_S4_VPU_HDMI_ID 2
+#define PWRC_S4_USB_COMB_ID 3
+#define PWRC_S4_GE2D_ID 4
+#define PWRC_S4_ETH_ID 5
+#define PWRC_S4_DEMOD_ID 6
+#define PWRC_S4_AUDIO_ID 7
+
+#endif
--
2.34.1