2022-03-23 21:21:47

by Christophe JAILLET

Subject: [PATCH] ARC: Remove a redundant memset()

disasm_instr() already call memset(0) on its 2nd argument, so there is no
need to clear it explicitly before calling this function.

Remove the redundant memset().

Signed-off-by: Christophe JAILLET <[email protected]>
---
arch/arc/kernel/disasm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arc/kernel/disasm.c b/arch/arc/kernel/disasm.c
index 03f8b1be0c3a..e9f16d9e113f 100644
--- a/arch/arc/kernel/disasm.c
+++ b/arch/arc/kernel/disasm.c
@@ -503,7 +503,6 @@ int __kprobes disasm_next_pc(unsigned long pc, struct pt_regs *regs,
{
struct disasm_state instr;

- memset(&instr, 0, sizeof(struct disasm_state));
disasm_instr(pc, &instr, 0, regs, cregs);

*next_pc = pc + instr.instr_len;
--
2.32.0

2022-04-19 19:54:08

by Vineet Gupta

Subject: Re: [PATCH] ARC: Remove a redundant memset()

On 3/22/22 12:49, Christophe JAILLET wrote:
> disasm_instr() already call memset(0) on its 2nd argument, so there is no
> need to clear it explicitly before calling this function.
>
> Remove the redundant memset().
>
> Signed-off-by: Christophe JAILLET<[email protected]>


Applied.

Thx,
-Vineet