2019-10-23 20:19:31

by Yue Haibing

Subject: [PATCH -next] memory: emif: remove set but not used variables 'cs1_used' and 'custom_configs'

drivers/memory/emif.c:1616:9: warning:
variable cs1_used set but not used [-Wunused-but-set-variable]
drivers/memory/emif.c:1624:36: warning:
variable custom_configs set but not used [-Wunused-but-set-variable]

They are never used since introduction.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/memory/emif.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 402c6bc..9d9127b 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -1613,7 +1613,7 @@ static void emif_shutdown(struct platform_device *pdev)
static int get_emif_reg_values(struct emif_data *emif, u32 freq,
struct emif_regs *regs)
{
- u32 cs1_used, ip_rev, phy_type;
+ u32 ip_rev, phy_type;
u32 cl, type;
const struct lpddr2_timings *timings;
const struct lpddr2_min_tck *min_tck;
@@ -1621,7 +1621,6 @@ static int get_emif_reg_values(struct emif_data *emif, u32 freq,
const struct lpddr2_addressing *addressing;
struct emif_data *emif_for_calc;
struct device *dev;
- const struct emif_custom_configs *custom_configs;

dev = emif->dev;
/*
@@ -1639,12 +1638,10 @@ static int get_emif_reg_values(struct emif_data *emif, u32 freq,

device_info = emif_for_calc->plat_data->device_info;
type = device_info->type;
- cs1_used = device_info->cs1_used;
ip_rev = emif_for_calc->plat_data->ip_rev;
phy_type = emif_for_calc->plat_data->phy_type;

min_tck = emif_for_calc->plat_data->min_tck;
- custom_configs = emif_for_calc->plat_data->custom_configs;

set_ddr_clk_period(freq);

--
2.7.4

2019-10-29 22:07:44

by Santosh Shilimkar

Subject: Re: [PATCH -next] memory: emif: remove set but not used variables 'cs1_used' and 'custom_configs'

On 10/23/19 6:51 AM, YueHaibing wrote:
> drivers/memory/emif.c:1616:9: warning:
> variable cs1_used set but not used [-Wunused-but-set-variable]
> drivers/memory/emif.c:1624:36: warning:
> variable custom_configs set but not used [-Wunused-but-set-variable]
>
> They are never used since introduction.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
Applied