2020-08-26 14:28:25

by Agrawal, Akshu

[permalink] [raw]
Subject: [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages

While the driver waits for DAIs to be probed and retries probing,
avoid printing error messages.

Signed-off-by: Akshu Agrawal <[email protected]>
---
sound/soc/amd/acp3x-rt5682-max9836.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c
index 406526e79af3..67f80ba51de0 100644
--- a/sound/soc/amd/acp3x-rt5682-max9836.c
+++ b/sound/soc/amd/acp3x-rt5682-max9836.c
@@ -471,13 +471,11 @@ static int acp3x_probe(struct platform_device *pdev)
}

ret = devm_snd_soc_register_card(&pdev->dev, card);
- if (ret) {
+ if (ret && ret != -EPROBE_DEFER)
dev_err(&pdev->dev,
"devm_snd_soc_register_card(%s) failed: %d\n",
card->name, ret);
- return ret;
- }
- return 0;
+ return ret;
}

static const struct acpi_device_id acp3x_audio_acpi_match[] = {
--
2.20.1


2020-08-26 14:29:08

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages

On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote:
> While the driver waits for DAIs to be probed and retries probing,
> avoid printing error messages.

This means that if there is a problem with deferred probe no diagnostics
will be available, there should be something at least at debug level.


Attachments:
(No filename) (314.00 B)
signature.asc (499.00 B)
Download all attachments

2020-08-26 18:38:57

by Agrawal, Akshu

[permalink] [raw]
Subject: Re: [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages


On 8/26/2020 4:54 PM, Mark Brown wrote:
> On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote:
>> While the driver waits for DAIs to be probed and retries probing,
>> avoid printing error messages.
> This means that if there is a problem with deferred probe no diagnostics
> will be available, there should be something at least at debug level.

Sure will add a message at debug level for deferred probe.

Thanks,
Akshu