2020-09-18 20:52:52

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c

On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool
>
> Signed-off-by: Zheng Bin <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <[email protected]>

Larry

>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> index 3c7ba8214daf..0748aedce2ad 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> @@ -858,7 +858,7 @@ static bool _rtl8723be_init_mac(struct ieee80211_hw *hw)
> rtl_write_word(rtlpriv, REG_CR, 0x2ff);
>
> if (!rtlhal->mac_func_enable) {
> - if (_rtl8723be_llt_table_init(hw) == false)
> + if (!_rtl8723be_llt_table_init(hw))
> return false;
> }
>
> --
> 2.26.0.106.g9fadedd
>