2018-03-01 13:18:38

by Harish Jenny K N

Subject: [PATCH] mmc: Export host capabilities to debugfs.

This patch exports the host capabilities to debugfs

Signed-off-by: Andrew Gabbasov <[email protected]>
Signed-off-by: Harish Jenny K N <[email protected]>
---
drivers/mmc/core/debugfs.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
index c51e0c0..fa2df7f 100644
--- a/drivers/mmc/core/debugfs.c
+++ b/drivers/mmc/core/debugfs.c
@@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)

card->debugfs_root = root;

+ if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))
+ goto err;
+
if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
goto err;

--
1.9.1

2018-03-01 14:25:17

by Linus Walleij

Subject: Re: [PATCH] mmc: Export host capabilities to debugfs.

On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
<[email protected]> wrote:

Thanks for your patch!

> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Andrew Gabbasov <[email protected]>
> Signed-off-by: Harish Jenny K N <[email protected]>

Is there a corresponding patch to the mmc utils to make use
of the exported information? An opaque u32 seems pretty hard
to interpret.

Yours,
Linus Walleij

2018-03-02 18:54:19

by Harish Jenny K N

Subject: Re: [PATCH] mmc: Export host capabilities to debugfs.

On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
> <[email protected]> wrote:
>
> Thanks for your patch!
>
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <[email protected]>
>> Signed-off-by: Harish Jenny K N <[email protected]>
> Is there a corresponding patch to the mmc utils to make use
> of the exported information? An opaque u32 seems pretty hard
> to interpret.
>
> Yours,
> Linus Walleij
A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.

Thanks,
Harish Jenny K N

2018-03-02 18:55:44

by Linus Walleij

Subject: Re: [PATCH] mmc: Export host capabilities to debugfs.

On Fri, Mar 2, 2018 at 2:17 PM, Harish Jenny K N
<[email protected]> wrote:
> On Thursday 01 March 2018 07:54 PM, Linus Walleij wrote:
>> On Thu, Mar 1, 2018 at 2:17 PM, Harish Jenny K N
>> <[email protected]> wrote:
>>
>> Thanks for your patch!
>>
>>> This patch exports the host capabilities to debugfs
>>>
>>> Signed-off-by: Andrew Gabbasov <[email protected]>
>>> Signed-off-by: Harish Jenny K N <[email protected]>
>> Is there a corresponding patch to the mmc utils to make use
>> of the exported information? An opaque u32 seems pretty hard
>> to interpret.
>>
>> Yours,
>> Linus Walleij
>
> A sample patch "[RFC PATCH] mmc-utils: host_caps: Add parser to read host capabilities" is submitted.

Nice! :)

Good work.

Yours,
Linus Walleij

2018-03-03 16:34:04

by Vladimir Zapolskiy

Subject: Re: [PATCH] mmc: Export host capabilities to debugfs.

Hi Harish,

On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Andrew Gabbasov <[email protected]>
> Signed-off-by: Harish Jenny K N <[email protected]>
> ---

would you mind to restore the authorship to Abbas Raza and send v2?

Thank you in advance.

--
With best wishes,
Vladimir

2018-03-05 04:25:18

by Harish Jenny K N

Subject: Re: [PATCH] mmc: Export host capabilities to debugfs.

On Saturday 03 March 2018 10:02 PM, Vladimir Zapolskiy wrote:
> Hi Harish,
>
> On 03/01/2018 03:17 PM, Harish Jenny K N wrote:
>> This patch exports the host capabilities to debugfs
>>
>> Signed-off-by: Andrew Gabbasov <[email protected]>
>> Signed-off-by: Harish Jenny K N <[email protected]>
>> ---
> would you mind to restore the authorship to Abbas Raza and send v2?
Sure. Abbas had left Mentor and this was being done as part of new project.
Still, I will resend the patch by changing the Author.

Thanks,
Harish