2015-02-23 16:11:12

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] regulator: da9211: Fix wrong register name in error message

We tried to read the CONFIG_E register, not the CONTROL_E register.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/regulator/da9211-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-regulator.c
index 01343419555ee336..3eda2dd577137f2a 100644
--- a/drivers/regulator/da9211-regulator.c
+++ b/drivers/regulator/da9211-regulator.c
@@ -344,7 +344,7 @@ static int da9211_regulator_init(struct da9211 *chip)

ret = regmap_read(chip->regmap, DA9211_REG_CONFIG_E, &data);
if (ret < 0) {
- dev_err(chip->dev, "Failed to read CONTROL_E reg: %d\n", ret);
+ dev_err(chip->dev, "Failed to read CONFIG_E reg: %d\n", ret);
return ret;
}

--
1.9.1


2015-02-24 00:58:25

by James Seong-Won Ban

[permalink] [raw]
Subject: RE: [PATCH] regulator: da9211: Fix wrong register name in error message

On February 24, 2015 1:11, Geert Uytterhoeven wrote:

> We tried to read the CONFIG_E register, not the CONTROL_E register.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/regulator/da9211-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-
> regulator.c
> index 01343419555ee336..3eda2dd577137f2a 100644
> --- a/drivers/regulator/da9211-regulator.c
> +++ b/drivers/regulator/da9211-regulator.c
> @@ -344,7 +344,7 @@ static int da9211_regulator_init(struct da9211 *chip)
>
> ret = regmap_read(chip->regmap, DA9211_REG_CONFIG_E, &data);
> if (ret < 0) {
> - dev_err(chip->dev, "Failed to read CONTROL_E reg: %d\n", ret);
> + dev_err(chip->dev, "Failed to read CONFIG_E reg: %d\n", ret);
> return ret;
> }
>
> --
> 1.9.1
Acked-by: James Ban <[email protected]>

2015-02-24 08:20:27

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: da9211: Fix wrong register name in error message

On Mon, Feb 23, 2015 at 05:11:07PM +0100, Geert Uytterhoeven wrote:
> We tried to read the CONFIG_E register, not the CONTROL_E register.

Applied, thanks.

Attachments:
(No filename) (156.00 B)
 signature.asc (473.00 B)
Digital signature Download all attachments