2015-02-23 16:12:23

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] regulator: da9211: Pass NULL data with OVER_CURRENT event

According to the documentation, no data is passed with the OVER_CURRENT
regulator notifier event.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/regulator/da9211-regulator.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-regulator.c
index 3eda2dd577137f2a..df79e4b1946e7d6e 100644
--- a/drivers/regulator/da9211-regulator.c
+++ b/drivers/regulator/da9211-regulator.c
@@ -305,8 +305,7 @@ static irqreturn_t da9211_irq_handler(int irq, void *data)

if (reg_val & DA9211_E_OV_CURR_A) {
regulator_notifier_call_chain(chip->rdev[0],
- REGULATOR_EVENT_OVER_CURRENT,
- rdev_get_drvdata(chip->rdev[0]));
+ REGULATOR_EVENT_OVER_CURRENT, NULL);

err = regmap_write(chip->regmap, DA9211_REG_EVENT_B,
DA9211_E_OV_CURR_A);
@@ -318,8 +317,7 @@ static irqreturn_t da9211_irq_handler(int irq, void *data)

if (reg_val & DA9211_E_OV_CURR_B) {
regulator_notifier_call_chain(chip->rdev[1],
- REGULATOR_EVENT_OVER_CURRENT,
- rdev_get_drvdata(chip->rdev[1]));
+ REGULATOR_EVENT_OVER_CURRENT, NULL);

err = regmap_write(chip->regmap, DA9211_REG_EVENT_B,
DA9211_E_OV_CURR_B);
--
1.9.1


2015-02-24 01:02:51

by James Seong-Won Ban

[permalink] [raw]
Subject: RE: [PATCH] regulator: da9211: Pass NULL data with OVER_CURRENT event

On February 24, 2015 1:12, Geert Uytterhoeven wrote:

> According to the documentation, no data is passed with the OVER_CURRENT
> regulator notifier event.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/regulator/da9211-regulator.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-
> regulator.c
> index 3eda2dd577137f2a..df79e4b1946e7d6e 100644
> --- a/drivers/regulator/da9211-regulator.c
> +++ b/drivers/regulator/da9211-regulator.c
> @@ -305,8 +305,7 @@ static irqreturn_t da9211_irq_handler(int irq, void *data)
>
> if (reg_val & DA9211_E_OV_CURR_A) {
> regulator_notifier_call_chain(chip->rdev[0],
> - REGULATOR_EVENT_OVER_CURRENT,
> - rdev_get_drvdata(chip->rdev[0]));
> + REGULATOR_EVENT_OVER_CURRENT, NULL);
>
> err = regmap_write(chip->regmap, DA9211_REG_EVENT_B,
> DA9211_E_OV_CURR_A);
> @@ -318,8 +317,7 @@ static irqreturn_t da9211_irq_handler(int irq, void *data)
>
> if (reg_val & DA9211_E_OV_CURR_B) {
> regulator_notifier_call_chain(chip->rdev[1],
> - REGULATOR_EVENT_OVER_CURRENT,
> - rdev_get_drvdata(chip->rdev[1]));
> + REGULATOR_EVENT_OVER_CURRENT, NULL);
>
> err = regmap_write(chip->regmap, DA9211_REG_EVENT_B,
> DA9211_E_OV_CURR_B);
> --
> 1.9.1
Acked-by: James Ban <[email protected]>

2015-02-24 08:20:33

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: da9211: Pass NULL data with OVER_CURRENT event

On Mon, Feb 23, 2015 at 05:12:16PM +0100, Geert Uytterhoeven wrote:
> According to the documentation, no data is passed with the OVER_CURRENT
> regulator notifier event.

Applied, thanks.

Attachments:
(No filename) (188.00 B)
 signature.asc (473.00 B)
Digital signature Download all attachments