2015-04-29 03:40:35

by Du, Changbin

[permalink] [raw]
Subject: [PATCH v2] usb: gadget: composite: enable BESL support

>From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Tue, 30 Sep 2014 16:08:03 -0500
Subject: [PATCH] usb: gadget: composite: enable BESL support

According to USB 2.0 ECN Errata for Link Power
Management (USB2-LPM-Errata-final.pdf), BESL
must be enabled if LPM is enabled.

This helps with USB30CV TD 9.21 LPM L1
Suspend Resume Test.

Cc: <[email protected]> # 3.1+: a661593: usb: enable BESL support
Signed-off-by: Felipe Balbi <[email protected]>
Signed-off-by: Du, Changbin <[email protected]>
---
Hi,

This patch was introduced on v3.18. However the issue fixed already existed on
v3.1. Thank Balbi for pointing it out.

So propose to backport it over all 3.1+ stable trees as well.

Du, Changbin
---
drivers/usb/gadget/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index a8c18df..f6a51fd 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev)
usb_ext->bLength = USB_DT_USB_EXT_CAP_SIZE;
usb_ext->bDescriptorType = USB_DT_DEVICE_CAPABILITY;
usb_ext->bDevCapabilityType = USB_CAP_TYPE_EXT;
- usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT);
+ usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPORT);

/*
* The Superspeed USB Capability descriptor shall be implemented by all
--
1.9.1


2015-04-29 05:56:13

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH v2] usb: gadget: composite: enable BESL support

Hi,

On Wed, Apr 29, 2015 at 03:40:28AM +0000, Du, Changbin wrote:
> From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <[email protected]>
> Date: Tue, 30 Sep 2014 16:08:03 -0500
> Subject: [PATCH] usb: gadget: composite: enable BESL support
>
> According to USB 2.0 ECN Errata for Link Power
> Management (USB2-LPM-Errata-final.pdf), BESL
> must be enabled if LPM is enabled.
>
> This helps with USB30CV TD 9.21 LPM L1
> Suspend Resume Test.
>
> Cc: <[email protected]> # 3.1+: a661593: usb: enable BESL support
> Signed-off-by: Felipe Balbi <[email protected]>
> Signed-off-by: Du, Changbin <[email protected]>

this is still not how you send a patch for stable, please have a look at
commits on the stable tree and mimic the format.

--
balbi


Attachments:
(No filename) (791.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments