As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
are mostly used today, let testusb tool use that directory as one default
path make tool be more convenient to use.
Signed-off-by: Du Changbin <[email protected]>
---
tools/usb/testusb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
index 6e0f567..c6c839e 100644
--- a/tools/usb/testusb.c
+++ b/tools/usb/testusb.c
@@ -358,6 +358,7 @@ static const char *usbfs_dir_find(void)
{
static char usbfs_path_0[] = "/dev/usb/devices";
static char usbfs_path_1[] = "/proc/bus/usb/devices";
+ static char udev_usb_path[] = "/dev/bus/usb";
static char *const usbfs_paths[] = {
usbfs_path_0, usbfs_path_1
@@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
}
} while (++it != end);
+ /* real device-nodes managed by udev */
+ if (access(udev_usb_path, F_OK) == 0) {
+ return udev_usb_path;
+ }
+
return NULL;
}
--
1.7.9.5
Hello.
On 14-05-2012 10:51, Du, ChangbinX wrote:
> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one default
> path make tool be more convenient to use.
> Signed-off-by: Du Changbin<[email protected]>
> ---
> tools/usb/testusb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index 6e0f567..c6c839e 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
[...]
> @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
> }
> } while (++it != end);
>
> + /* real device-nodes managed by udev */
> + if (access(udev_usb_path, F_OK) == 0) {
> + return udev_usb_path;
> + }
Why {} with single statement?
WBR, Sergei
Hello.
On 14-05-2012 10:51, Du, ChangbinX wrote:
> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one
> default path make tool be more convenient to use.
> Signed-off-by: Du Changbin<[email protected]>
> ---
> tools/usb/testusb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index
> 6e0f567..c6c839e 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
[...]
> @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
> }
> } while (++it != end);
>
> + /* real device-nodes managed by udev */
> + if (access(udev_usb_path, F_OK) == 0) {
> + return udev_usb_path;
> + }
Why {} with single statement?
Hi, thanks for your tip. It's a code style issue. I will remove {}.
By the way, I don't know how I can do with this case? Resend a new patch? Do I need include discussion message in new patch mail?
And how can I know my patch has be accepted? I am a newbie, could you help me?
Changbin
WBR, Sergei
On 14-05-2012 14:49, Du, ChangbinX wrote:
>> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
>> are mostly used today, let testusb tool use that directory as one
>> default path make tool be more convenient to use.
>> Signed-off-by: Du Changbin<[email protected]>
>> ---
>> tools/usb/testusb.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index
>> 6e0f567..c6c839e 100644
>> --- a/tools/usb/testusb.c
>> +++ b/tools/usb/testusb.c
> [...]
>> @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
>> }
>> } while (++it != end);
>>
>> + /* real device-nodes managed by udev */
>> + if (access(udev_usb_path, F_OK) == 0) {
>> + return udev_usb_path;
>> + }
> Why {} with single statement?
> Hi, thanks for your tip. It's a code style issue. I will remove {}.
> By the way, I don't know how I can do with this case? Resend a new patch?
Yes, marking that thsi is a new version of patch in the [PATCH] prefix,
like [PATCH v2].
> Do I need include discussion message in new patch mail?
Not necessarily, just indicate the change compared to the old version
under the --- tear line.
> And how can I know my patch has be accepted? I am a newbie, could you help me?
You will get a reply from the maintainer, Greg Kroah-Hartman, I think.
> Changbin
WBR, Sergei
On Mon, May 14, 2012 at 10:49:06AM +0000, Du, ChangbinX wrote:
>
> Hello.
>
> On 14-05-2012 10:51, Du, ChangbinX wrote:
>
> > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> > are mostly used today, let testusb tool use that directory as one
> > default path make tool be more convenient to use.
>
> > Signed-off-by: Du Changbin<[email protected]>
> > ---
> > tools/usb/testusb.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index
> > 6e0f567..c6c839e 100644
> > --- a/tools/usb/testusb.c
> > +++ b/tools/usb/testusb.c
> [...]
> > @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
> > }
> > } while (++it != end);
> >
> > + /* real device-nodes managed by udev */
> > + if (access(udev_usb_path, F_OK) == 0) {
> > + return udev_usb_path;
> > + }
>
> Why {} with single statement?
>
> Hi, thanks for your tip. It's a code style issue. I will remove {}.
>
> By the way, I don't know how I can do with this case? Resend a new
> patch? Do I need include discussion message in new patch mail?
Please resend a new patch with this fixed up.
> And how can I know my patch has be accepted? I am a newbie, could you
> help me?
You will get an automated email from my patch system when it is applied.
thanks,
greg k-h
> By the way, I don't know how I can do with this case? Resend a new patch?
Yes, marking that thsi is a new version of patch in the [PATCH] prefix, like [PATCH v2].
> Do I need include discussion message in new patch mail?
Not necessarily, just indicate the change compared to the old version under the --- tear line.
> And how can I know my patch has be accepted? I am a newbie, could you help me?
You will get a reply from the maintainer, Greg Kroah-Hartman, I think.
> Changbin
WBR, Sergei
That's very nice of you, thanks a lot!
Du Changbin