2012-05-22 06:50:41

by Du, ChangbinX

Subject: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs

As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
are mostly used today, let testusb tool use that directory as one default
path make tool be more convenient to use.

Signed-off-by: Du Changbin <[email protected]>
---
tools/usb/testusb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
index 6e0f567..0aac3ff 100644
--- a/tools/usb/testusb.c
+++ b/tools/usb/testusb.c
@@ -358,9 +358,11 @@ static const char *usbfs_dir_find(void)
{
static char usbfs_path_0[] = "/dev/usb/devices";
static char usbfs_path_1[] = "/proc/bus/usb/devices";
+ /* real device-nodes managed by udev */
+ static char udev_usb_path[] = "/dev/bus/usb/";

static char *const usbfs_paths[] = {
- usbfs_path_0, usbfs_path_1
+ usbfs_path_0, usbfs_path_1, udev_usb_path,
};

static char *const *
--
1.7.9.5

2012-05-22 22:42:39

by David Rientjes

Subject: Re: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs

On Tue, 22 May 2012, Du, ChangbinX wrote:

> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one default
> path make tool be more convenient to use.
>
> Signed-off-by: Du Changbin <[email protected]>

Acked-by: David Rientjes <[email protected]>

2012-06-13 23:15:45

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs

On Tue, May 22, 2012 at 06:50:24AM +0000, Du, ChangbinX wrote:
> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one default
> path make tool be more convenient to use.
>
> Signed-off-by: Du Changbin <[email protected]>

This patch does not apply, what tree did you make it against? Can you
redo it against the next linux-next release and resend it so I can apply
it?

thanks,

greg k-h

2012-06-14 01:57:25

by Du, ChangbinX

Subject: RE: [PATCH v3] testusb: add path /dev/bus/usb to default search paths of usbfs

> On Tue, May 22, 2012 at 06:50:24AM +0000, Du, ChangbinX wrote:
> > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> > are mostly used today, let testusb tool use that directory as one
> > default path make tool be more convenient to use.
> >
> > Signed-off-by: Du Changbin <[email protected]>
>
> This patch does not apply, what tree did you make it against? Can you redo it
> against the next linux-next release and resend it so I can apply it?

I am very sorry about this. I found this patch has already applied on your tree a
Month ago. But I had missed the response mail and resent the patch a week later.
I think you could just drop this patch because it has no different with last one.

Thanks!
Changbin

>
> thanks,
>
> greg k-h