2005-03-08 23:14:45

by Bagalkote, Sreenivas

[permalink] [raw]
Subject: RE: [ANNOUNCE][PATCH 2.6.11 1/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

>
>> source "drivers/scsi/megaraid/Kconfig.megaraid"
>> +source "drivers/scsi/megaraid/Kconfig.megaraid_sas"
>>
>
>why a fully separate file and not add your ONE config option to
>Kconfig.megaraid instead ??
>

Arjan, I didn't want to needlessly couple megaraid and megaraid_sas.
Since they are in the same directory, I couldn't avoid having single
Makefile. I thought at least these two should be separate to be consistent
with their independent nature.

If this is not a good enough reason, I will merge these two files.

Thanks,
Sreenivas


2005-03-09 01:15:30

by Adrian Bunk

[permalink] [raw]
Subject: Re: [ANNOUNCE][PATCH 2.6.11 1/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

On Tue, Mar 08, 2005 at 06:05:11PM -0500, Bagalkote, Sreenivas wrote:
> >
> >> source "drivers/scsi/megaraid/Kconfig.megaraid"
> >> +source "drivers/scsi/megaraid/Kconfig.megaraid_sas"
> >>
> >
> >why a fully separate file and not add your ONE config option to
> >Kconfig.megaraid instead ??
> >
>
> Arjan, I didn't want to needlessly couple megaraid and megaraid_sas.
> Since they are in the same directory, I couldn't avoid having single
> Makefile. I thought at least these two should be separate to be consistent
> with their independent nature.
>
> If this is not a good enough reason, I will merge these two files.

Please merge them.

Whether they are in the same Kconfig file or not does not in any way
imply any relation between them.

E.g. drivers/scsi/Kconfig contains many drivers that are not in any way
coupled to each other.

> Thanks,
> Sreenivas

cu
Adrian

BTW: Why does the text say "(New Driver)"?

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed