2009-03-15 05:38:54

by Kyle McMartin

Subject: [PATCH trivial] cpqarray: enable bus mastering

From: Dave Jones <[email protected]>

We've been carrying this patch for the last 3 years in Fedora,
long past time we got it upstream...

Call pci_set_master to enable bus-mastering if the BIOS hasn't
done it already.

Signed-off-by: Kyle McMartin <[email protected]>
Signed-off-by: Dave Jones <[email protected]>

--- a/drivers/block/cpqarray.c 2006-10-06 14:23:34.000000000 -0400
+++ b/drivers/block/cpqarray.c 2006-10-06 14:25:16.000000000 -0400
@@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
int i;

c->pci_dev = pdev;
+ pci_set_master(pdev);
if (pci_enable_device(pdev)) {
printk(KERN_ERR "cpqarray: Unable to Enable PCI device\n");
return -1;

2009-03-16 09:05:35

by Jens Axboe

Subject: Re: [PATCH trivial] cpqarray: enable bus mastering

On Sun, Mar 15 2009, Kyle McMartin wrote:
> From: Dave Jones <[email protected]>
>
> We've been carrying this patch for the last 3 years in Fedora,
> long past time we got it upstream...
>
> Call pci_set_master to enable bus-mastering if the BIOS hasn't
> done it already.
>
> Signed-off-by: Kyle McMartin <[email protected]>
> Signed-off-by: Dave Jones <[email protected]>
>
> --- a/drivers/block/cpqarray.c 2006-10-06 14:23:34.000000000 -0400
> +++ b/drivers/block/cpqarray.c 2006-10-06 14:25:16.000000000 -0400
> @@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
> int i;
>
> c->pci_dev = pdev;
> + pci_set_master(pdev);
> if (pci_enable_device(pdev)) {
> printk(KERN_ERR "cpqarray: Unable to Enable PCI device\n");
> return -1;

Thanks Kyle, looks pretty innocent. Queued up for 2.6.30.

--
Jens Axboe

2009-03-16 15:46:38

by Mike Miller

Subject: RE: [PATCH trivial] cpqarray: enable bus mastering

> -----Original Message-----
> From: Jens Axboe [mailto:[email protected]]
> Sent: Monday, March 16, 2009 4:05 AM
> To: Kyle McMartin
> Cc: Miller, Mike (OS Dev); [email protected]
> Subject: Re: [PATCH trivial] cpqarray: enable bus mastering
>
> On Sun, Mar 15 2009, Kyle McMartin wrote:
> > From: Dave Jones <[email protected]>
> >
> > We've been carrying this patch for the last 3 years in Fedora, long
> > past time we got it upstream...
> >
> > Call pci_set_master to enable bus-mastering if the BIOS
> hasn't done it
> > already.
> >
> > Signed-off-by: Kyle McMartin <[email protected]>
> > Signed-off-by: Dave Jones <[email protected]>
> >
> > --- a/drivers/block/cpqarray.c 2006-10-06
> 14:23:34.000000000 -0400
> > +++ b/drivers/block/cpqarray.c 2006-10-06
> 14:25:16.000000000 -0400
> > @@ -614,6 +614,7 @@ static int cpqarray_pci_init(ctlr_info_t
> > int i;
> >
> > c->pci_dev = pdev;
> > + pci_set_master(pdev);
> > if (pci_enable_device(pdev)) {
> > printk(KERN_ERR "cpqarray: Unable to Enable PCI
> device\n");
> > return -1;
>
> Thanks Kyle, looks pretty innocent. Queued up for 2.6.30.
>
> --
> Jens Axboe

Reviewed-by: Mike Miller <[email protected]>
>
> -