nommu/mpu patch set against 2.6.12-rc3-mm3 [7/17]
- platform patch for atmel
arch/arm/mach-atmel/Kconfig | 61 +++++++
arch/arm/mach-atmel/Makefile | 7
arch/arm/mach-atmel/Makefile.boot | 2
arch/arm/mach-atmel/arch.c | 56 ++++++
arch/arm/mach-atmel/head.S | 83 ++++++++++
arch/arm/mach-atmel/irq.c | 215 ++++++++++++++++++++++++++
arch/arm/mach-atmel/time.c | 101 ++++++++++++
include/asm-arm/arch-atmel/at91x40.h | 57 ++++++
include/asm-arm/arch-atmel/at91x63.h | 73 ++++++++
include/asm-arm/arch-atmel/dma.h | 26 +++
include/asm-arm/arch-atmel/entry-macro.S | 39 ++++
include/asm-arm/arch-atmel/hardware.h | 255
+++++++++++++++++++++++++++++++
include/asm-arm/arch-atmel/io.h | 40 ++++
include/asm-arm/arch-atmel/irq.h | 22 ++
include/asm-arm/arch-atmel/irqs.h | 65 +++++++
include/asm-arm/arch-atmel/keyboard.h | 21 ++
include/asm-arm/arch-atmel/memory.h | 30 +++
include/asm-arm/arch-atmel/param.h | 6
include/asm-arm/arch-atmel/sizes.h | 52 ++++++
include/asm-arm/arch-atmel/system.h | 42 +++++
include/asm-arm/arch-atmel/time.h | 29 +++
include/asm-arm/arch-atmel/timex.h | 10 +
include/asm-arm/arch-atmel/uncompress.h | 58 +++++++
include/asm-arm/arch-atmel/vmalloc.h | 35 ++++
24 files changed, 1385 insertions(+)
Signed-off-by: Hyok S. Choi <[email protected]>
the patch :
http://opensrc.sec.samsung.com/download/linux-2.6.12-rc3-mm3-hsc0-atmel.patc
h.bz2
---
Hyok S. Choi
[Linux 2.6 for MMU-less ARM Project] http://opensrc.sec.samsung.com/
On Saturday 07 May 2005 08:10, Hyok S. Choi wrote:
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/Makefile
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/Makefile
> +#
> +# Makefile for the linux kernel.
> +#
> +# Object file lists.
Useless comments.
> +obj-y += arch.o irq.o time.o
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/arch.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/arch.c
[21 #include directives snipped]
> +extern void atmel_time_init(void);
> +extern unsigned long atmel_gettimeoffset(void);
> +
> +extern void __init atmel_init_irq(void);
> +
> +extern struct sys_timer atmel_timer;
> +
> +MACHINE_START(ATMEL, "ATMEL EB01")
> + MAINTAINER("Hyok S. Choi <[email protected]>")
> + INITIRQ(atmel_init_irq)
> + .timer = &atmel_timer,
> +MACHINE_END
So, all you need is:
include/linux/init.h
include/asm-arm/mach/time.h
include/asm-arm/mach/arch.h
And maybe one or two more.
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/irq.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/irq.c
> +static unsigned char eb01_irq_prtable[32] = {
Should it be ...[NR_IRQS] ?
> + 7 << 5, /* FIQ */
> + 0 << 5, /* SWIRQ */
> + 0 << 5, /* US0IRQ */
> + 0 << 5, /* US1IRQ */
> + 2 << 5, /* TC0IRQ */
> + 2 << 5, /* TC1IRQ */
> + 2 << 5, /* TC2IRQ */
> + 0 << 5, /* WDIRQ */
> + 0 << 5, /* PIOAIRQ */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 1 << 5, /* IRQ0 */
> + 0 << 5, /* IRQ1 */
> + 0 << 5, /* IRQ2 */
> +};
You are doing "eb01_irq_prtable[irq] >> 5" always.
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel(irq, AIC_EOICR);
> + }
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel((eb01_irq_prtable[irq] >> 5) | eb01_irq_type[irq],
> + AIC_SMR(irq));
> + }
Use consistent style for "for" statements and brackets. Like in the next line.
> + for (irq = 0; irq < NR_IRQS; irq++) {
Please, remove trailing whitespace from this patch. There is quite a few of
it.
Here is the refined atmel patch of nommu/mpu patch set against
2.6.12-rc3-mm3 [7/17]
which accepted all the Alexey Dobriyan's comments.
- platform patch for atmel
arch/arm/mach-atmel/Kconfig | 61 +++++++
arch/arm/mach-atmel/Makefile | 1
arch/arm/mach-atmel/Makefile.boot | 2
arch/arm/mach-atmel/arch.c | 37 ++++
arch/arm/mach-atmel/head.S | 83 ++++++++++
arch/arm/mach-atmel/irq.c | 212 +++++++++++++++++++++++++
arch/arm/mach-atmel/time.c | 100 ++++++++++++
include/asm-arm/arch-atmel/at91x40.h | 57 ++++++
include/asm-arm/arch-atmel/at91x63.h | 73 ++++++++
include/asm-arm/arch-atmel/dma.h | 26 +++
include/asm-arm/arch-atmel/entry-macro.S | 39 ++++
include/asm-arm/arch-atmel/hardware.h | 255
+++++++++++++++++++++++++++++++
include/asm-arm/arch-atmel/io.h | 40 ++++
include/asm-arm/arch-atmel/irq.h | 22 ++
include/asm-arm/arch-atmel/irqs.h | 65 +++++++
include/asm-arm/arch-atmel/keyboard.h | 21 ++
include/asm-arm/arch-atmel/memory.h | 30 +++
include/asm-arm/arch-atmel/param.h | 6
include/asm-arm/arch-atmel/sizes.h | 52 ++++++
include/asm-arm/arch-atmel/system.h | 42 +++++
include/asm-arm/arch-atmel/time.h | 29 +++
include/asm-arm/arch-atmel/timex.h | 10 +
include/asm-arm/arch-atmel/uncompress.h | 58 +++++++
include/asm-arm/arch-atmel/vmalloc.h | 35 ++++
24 files changed, 1356 insertions(+)
Signed-off-by: Hyok S. Choi <[email protected]>
the patch :
http://opensrc.sec.samsung.com/download/linux-2.6.12-rc3-mm3-hsc0-atmel2.pat
ch.bz2
---
Hyok S. Choi
[Linux 2.6 for MMU-less ARM Project] http://opensrc.sec.samsung.com/