2009-03-19 17:44:25

by Gilles Espinasse

Subject: [PATCH] Be able to build pmac driver without IDE built-in

No reason to need IDE built-in to be able to compile pmac driver
Tested to work on 2.6.29-rc8 and 2.6.28.8 with ide and pmac as modules
inside an initramfs

Signed-off-by: Gilles Espinasse <[email protected]>

--- linux-2.6.28/drivers/ide/Kconfig.old 2009-03-19 16:36:34.000000000 +0100
+++ linux-2.6.28/drivers/ide/Kconfig 2009-03-19 16:35:49.000000000 +0100
@@ -676,7 +676,7 @@
# TODO: BLK_DEV_IDEDMA_PCI -> BLK_DEV_IDEDMA_SFF
config BLK_DEV_IDE_PMAC
tristate "PowerMac on-board IDE support"
- depends on PPC_PMAC && IDE=y
+ depends on PPC_PMAC && IDE
select IDE_TIMINGS
select BLK_DEV_IDEDMA_PCI
help

2009-03-23 20:09:58

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH] Be able to build pmac driver without IDE built-in

On Thursday 19 March 2009, Gilles Espinasse wrote:
> No reason to need IDE built-in to be able to compile pmac driver
> Tested to work on 2.6.29-rc8 and 2.6.28.8 with ide and pmac as modules
> inside an initramfs
>
> Signed-off-by: Gilles Espinasse <[email protected]>

applied by hand (please check your mailer settings
as it seems to corrupt whitespaces)

> --- linux-2.6.28/drivers/ide/Kconfig.old 2009-03-19 16:36:34.000000000 +0100
> +++ linux-2.6.28/drivers/ide/Kconfig 2009-03-19 16:35:49.000000000 +0100
> @@ -676,7 +676,7 @@
> # TODO: BLK_DEV_IDEDMA_PCI -> BLK_DEV_IDEDMA_SFF
> config BLK_DEV_IDE_PMAC
> tristate "PowerMac on-board IDE support"
> - depends on PPC_PMAC && IDE=y
> + depends on PPC_PMAC && IDE

IDE config options are covered by if IDE ... endif so no need to check
for IDE explicitly now (I cleaned this while applying the patch)