2019-09-08 12:25:17

by Shuah Khan

[permalink] [raw]
Subject: [PATCH v4 4/5] doc: media: vimc: Update module parameter usage information

vimc driver is now a monolithic driver. Update the module parameter
usage information to reflect that.

Signed-off-by: Shuah Khan <[email protected]>
---
Documentation/media/v4l-drivers/vimc.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst
index 406417680db5..a582af0509ee 100644
--- a/Documentation/media/v4l-drivers/vimc.rst
+++ b/Documentation/media/v4l-drivers/vimc.rst
@@ -76,22 +76,22 @@ vimc-capture:
* 1 Pad sink
* 1 Pad source

-Module options
+
+ Module options
---------------

-Vimc has a few module parameters to configure the driver. You should pass
-those arguments to each subdevice, not to the vimc module. For example::
+Vimc has a few module parameters to configure the driver.

- vimc_subdevice.param=value
+ param=value

-* ``vimc_scaler.sca_mult=<unsigned int>``
+* ``sca_mult=<unsigned int>``

Image size multiplier factor to be used to multiply both width and
height, so the image size will be ``sca_mult^2`` bigger than the
original one. Currently, only supports scaling up (the default value
is 3).

-* ``vimc_debayer.deb_mean_win_size=<unsigned int>``
+* ``deb_mean_win_size=<unsigned int>``

Window size to calculate the mean. Note: the window size needs to be an
odd number, as the main pixel stays in the center of the window,
--
2.20.1


2019-09-16 01:35:31

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH v4 4/5] doc: media: vimc: Update module parameter usage information



On 9/6/19 11:42 PM, Shuah Khan wrote:
> vimc driver is now a monolithic driver. Update the module parameter
> usage information to reflect that.
>
> Signed-off-by: Shuah Khan <[email protected]>

Acked-by: Helen Koike <[email protected]>

> ---
> Documentation/media/v4l-drivers/vimc.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst
> index 406417680db5..a582af0509ee 100644
> --- a/Documentation/media/v4l-drivers/vimc.rst
> +++ b/Documentation/media/v4l-drivers/vimc.rst
> @@ -76,22 +76,22 @@ vimc-capture:
> * 1 Pad sink
> * 1 Pad source
>
> -Module options
> +
> + Module options
> ---------------
>
> -Vimc has a few module parameters to configure the driver. You should pass
> -those arguments to each subdevice, not to the vimc module. For example::
> +Vimc has a few module parameters to configure the driver.
>
> - vimc_subdevice.param=value
> + param=value
>
> -* ``vimc_scaler.sca_mult=<unsigned int>``
> +* ``sca_mult=<unsigned int>``
>
> Image size multiplier factor to be used to multiply both width and
> height, so the image size will be ``sca_mult^2`` bigger than the
> original one. Currently, only supports scaling up (the default value
> is 3).
>
> -* ``vimc_debayer.deb_mean_win_size=<unsigned int>``
> +* ``deb_mean_win_size=<unsigned int>``
>
> Window size to calculate the mean. Note: the window size needs to be an
> odd number, as the main pixel stays in the center of the window,
>