The Mt. Mitchell BMC is an ASPEED AST2600-based BMC for the Mt. Mitchell
hardware reference platform with AmpereOne(TM) processor.
v2 :
+ Add Ampere Mt. Mitchell BMC compatible [Krzysztof]
+ Remove bootargs [Krzysztof]
+ Fix gpio-keys nodes name to conform with device tree binding
documents [Krzysztof]
+ Fix some nodes to use generic name [Krzysztof]
+ Remove unnecessary blank line [Krzysztof]
+ Fix typo "LTC" to "LLC" in license info and corrected license
info to GPL-2.0-only
Quan Nguyen (2):
dt-bindings: arm: aspeed: document Ampere Mt.Mitchell BMC compatibles
ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC
.../bindings/arm/aspeed/aspeed.yaml | 1 +
arch/arm/boot/dts/Makefile | 1 +
.../boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 577 ++++++++++++++++++
3 files changed, 579 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
--
2.35.1
Document Ampere Mt.Mitchell BMC board compatible.
Signed-off-by: Quan Nguyen <[email protected]>
---
v2:
+ Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof]
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index d61408194998..b8146d5c4431 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -71,6 +71,7 @@ properties:
- enum:
- aspeed,ast2600-evb
- aspeed,ast2600-evb-a1
+ - ampere,mtmitchell-bmc
- facebook,bletchley-bmc
- facebook,cloudripper-bmc
- facebook,elbert-bmc
--
2.35.1
On 20/07/2022 10:52, Quan Nguyen wrote:
> Document Ampere Mt.Mitchell BMC board compatible.
>
> Signed-off-by: Quan Nguyen <[email protected]>
Thank you for your patch. There is something to discuss/improve.
> ---
> v2:
> + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof]
>
> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index d61408194998..b8146d5c4431 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -71,6 +71,7 @@ properties:
> - enum:
> - aspeed,ast2600-evb
> - aspeed,ast2600-evb-a1
> + - ampere,mtmitchell-bmc
Put the entry ordered alphabetically.
Best regards,
Krzysztof
On 20/07/2022 17:34, Krzysztof Kozlowski wrote:
> On 20/07/2022 10:52, Quan Nguyen wrote:
>> Document Ampere Mt.Mitchell BMC board compatible.
>>
>> Signed-off-by: Quan Nguyen <[email protected]>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> ---
>> v2:
>> + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof]
>>
>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> index d61408194998..b8146d5c4431 100644
>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> @@ -71,6 +71,7 @@ properties:
>> - enum:
>> - aspeed,ast2600-evb
>> - aspeed,ast2600-evb-a1
>> + - ampere,mtmitchell-bmc
>
> Put the entry ordered alphabetically.
>
Thanks Krzysztof for the review.
Will change to :
- enum:
+ - ampere,mtmitchell-bmc
- aspeed,ast2600-evb
- aspeed,ast2600-evb-a1
But, should we correct the below as well? ie: to move
"ampere,mtjade-bmc" to before "aspeed,ast2500-evb" ?
- description: AST2500 based boards
items:
- enum:
- aspeed,ast2500-evb
- amd,ethanolx-bmc
- ampere,mtjade-bmc
- asrock,e3c246d4i-bmc
Thanks,
- Quan
On 21/07/2022 04:46, Quan Nguyen wrote:
>
>
> On 20/07/2022 17:34, Krzysztof Kozlowski wrote:
>> On 20/07/2022 10:52, Quan Nguyen wrote:
>>> Document Ampere Mt.Mitchell BMC board compatible.
>>>
>>> Signed-off-by: Quan Nguyen <[email protected]>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> ---
>>> v2:
>>> + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof]
>>>
>>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>> index d61408194998..b8146d5c4431 100644
>>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>> @@ -71,6 +71,7 @@ properties:
>>> - enum:
>>> - aspeed,ast2600-evb
>>> - aspeed,ast2600-evb-a1
>>> + - ampere,mtmitchell-bmc
>>
>> Put the entry ordered alphabetically.
>>
>
> Thanks Krzysztof for the review.
>
> Will change to :
> - enum:
> + - ampere,mtmitchell-bmc
> - aspeed,ast2600-evb
> - aspeed,ast2600-evb-a1
>
> But, should we correct the below as well? ie: to move
> "ampere,mtjade-bmc" to before "aspeed,ast2500-evb" ?
>
Oops, indeed, I added aspeed in wrong place. I'll correct it in my tree.
Best regards,
Krzysztof