2020-11-25 02:42:30

by Christian Hewitt

[permalink] [raw]
Subject: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2

From: Artem Lapkin <[email protected]>

The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
chip should be 104Mhz not 30MHz.

Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
Signed-off-by: Artem Lapkin <[email protected]>
---
This change was previously submitted as [0] which has style issues and
remains unmerged. It is also part of a two patch series where the other
patch needs further work to convert to newer LED bindings.

[0] https://patchwork.kernel.org/project/linux-amlogic/patch/[email protected]/

arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 39e6047056b2..079500ed5066 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -391,7 +391,7 @@
#size-cells = <1>;
compatible = "winbond,w25q16", "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <3000000>;
+ spi-max-frequency = <104000000>;
};
};

--
2.17.1


2020-11-30 13:29:42

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2

On 25/11/2020 03:40, Christian Hewitt wrote:
> From: Artem Lapkin <[email protected]>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <[email protected]>
> ---
> This change was previously submitted as [0] which has style issues and
> remains unmerged. It is also part of a two patch series where the other
> patch needs further work to convert to newer LED bindings.
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/[email protected]/
>
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 39e6047056b2..079500ed5066 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -391,7 +391,7 @@
> #size-cells = <1>;
> compatible = "winbond,w25q16", "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <3000000>;
> + spi-max-frequency = <104000000>;
> };
> };
>
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-11-30 13:30:03

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2

On 25/11/2020 03:40, Christian Hewitt wrote:
> From: Artem Lapkin <[email protected]>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <[email protected]>
> ---
> This change was previously submitted as [0] which has style issues and
> remains unmerged. It is also part of a two patch series where the other
> patch needs further work to convert to newer LED bindings.
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/[email protected]/
>
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 39e6047056b2..079500ed5066 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -391,7 +391,7 @@
> #size-cells = <1>;
> compatible = "winbond,w25q16", "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <3000000>;
> + spi-max-frequency = <104000000>;
> };
> };
>
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-12-05 18:37:49

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2

On Wed, Nov 25, 2020 at 3:40 AM Christian Hewitt
<[email protected]> wrote:
>
> From: Artem Lapkin <[email protected]>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>