This is the start of the stable review cycle for the 5.10.211 release.
There are 122 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.10.211-rc1
Baokun Li <[email protected]>
ext4: regenerate buddy after block freeing failed if under fc replay
Kuniyuki Iwashima <[email protected]>
arp: Prevent overflow in arp_req_get().
Bart Van Assche <[email protected]>
fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio
Michael Schmitz <[email protected]>
block: ataflop: more blk-mq refactoring fixes
Armin Wolf <[email protected]>
drm/amd/display: Fix memory leak in dm_sw_fini()
Erik Kurzinger <[email protected]>
drm/syncobj: call drm_syncobj_fence_add_wait when WAIT_AVAILABLE flag is set
Christian König <[email protected]>
drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v3
Florian Westphal <[email protected]>
netfilter: nf_tables: set dormant flag on hook register failure
Sabrina Dubroca <[email protected]>
tls: stop recv() if initial process_rx_list gave us non-DATA
Jakub Kicinski <[email protected]>
tls: rx: drop pointless else after goto
Jakub Kicinski <[email protected]>
tls: rx: jump to a more appropriate label
Jason Gunthorpe <[email protected]>
s390: use the correct count for __iowrite64_copy()
Kees Cook <[email protected]>
net: dev: Convert sa_data to flexible array in struct sockaddr
Wolfram Sang <[email protected]>
packet: move from strlcpy with unused retval to strscpy
Vasiliy Kovalev <[email protected]>
ipv6: sr: fix possible use-after-free and null-ptr-deref
Daniil Dulov <[email protected]>
afs: Increase buffer size in afs_update_volume_status()
Eric Dumazet <[email protected]>
ipv6: properly combine dev_base_seq and ipv6.dev_addr_genid
Eric Dumazet <[email protected]>
ipv4: properly combine dev_base_seq and ipv4.dev_addr_genid
Arnd Bergmann <[email protected]>
nouveau: fix function cast warnings
Randy Dunlap <[email protected]>
scsi: jazz_esp: Only build if SCSI core is builtin
Gianmarco Lusvardi <[email protected]>
bpf, scripts: Correct GPL license name
Arnd Bergmann <[email protected]>
RDMA/srpt: fix function pointer cast warnings
Heiko Stuebner <[email protected]>
arm64: dts: rockchip: set num-cs property for spi on px30
Kamal Heib <[email protected]>
RDMA/qedr: Fix qedr_create_user_qp error flow
Bart Van Assche <[email protected]>
RDMA/srpt: Support specifying the srpt_service_guid parameter
Kalesh AP <[email protected]>
RDMA/bnxt_re: Return error for SRQ resize
Zhipeng Lu <[email protected]>
IB/hfi1: Fix a memleak in init_credit_return
Paolo Abeni <[email protected]>
mptcp: fix lockless access in subflow ULP diag
Xu Yang <[email protected]>
usb: roles: don't get/set_role() when usb_role_switch is unregistered
Xu Yang <[email protected]>
usb: roles: fix NULL pointer issue when put module's reference
Krishna Kurapati <[email protected]>
usb: gadget: ncm: Avoid dropping datagrams of properly parsed NTBs
Frank Li <[email protected]>
usb: cdns3: fix memory double free when handle zero packet
Frank Li <[email protected]>
usb: cdns3: fixed memory use after free at cdns3_gadget_ep_disable()
Peter Zijlstra <[email protected]>
x86/alternative: Make custom return thunk unconditional
Borislav Petkov (AMD) <[email protected]>
Revert "x86/alternative: Make custom return thunk unconditional"
Peter Zijlstra <[email protected]>
x86/returnthunk: Allow different return thunks
Peter Zijlstra <[email protected]>
x86/ftrace: Use alternative RET encoding
Peter Zijlstra <[email protected]>
x86/ibt,paravirt: Use text_gen_insn() for paravirt_patch()
Peter Zijlstra <[email protected]>
x86/text-patching: Make text_gen_insn() play nice with ANNOTATE_NOENDBR
Borislav Petkov (AMD) <[email protected]>
Revert "x86/ftrace: Use alternative RET encoding"
Nikita Shubin <[email protected]>
ARM: ep93xx: Add terminator to gpiod_lookup_table
Tom Parkin <[email protected]>
l2tp: pass correct message length to ip6_append_data
Vidya Sagar <[email protected]>
PCI/MSI: Prevent MSI hardware interrupt number truncation
Vasiliy Kovalev <[email protected]>
gtp: fix use-after-free and null-ptr-deref in gtp_genl_dump_pdp()
Oliver Upton <[email protected]>
KVM: arm64: vgic-its: Test for valid IRQ in its_sync_lpi_pending_table()
Oliver Upton <[email protected]>
KVM: arm64: vgic-its: Test for valid IRQ in MOVALL handler
Mikulas Patocka <[email protected]>
dm-crypt: don't modify the data when using authenticated encryption
Peter Oberparleiter <[email protected]>
s390/cio: fix invalid -EBUSY on ccw_device_start
Daniel Vacek <[email protected]>
IB/hfi1: Fix sdma.h tx->num_descs off-by-one error
Gao Xiang <[email protected]>
erofs: fix lz4 inplace decompression
Jan Beulich <[email protected]>
x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()
Zhihao Cheng <[email protected]>
jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint
Zhang Yi <[email protected]>
jbd2: recheck chechpointing non-dirty buffer
Zhang Yi <[email protected]>
jbd2: remove redundant buffer io error checks
Johannes Berg <[email protected]>
iwlwifi: mvm: write queue_sync_state only for sync
Johannes Berg <[email protected]>
iwlwifi: mvm: do more useful queue sync accounting
Max Verevkin <[email protected]>
platform/x86: intel-vbtn: Support for tablet mode on HP Pavilion 13 x360 PC
Sergej Bauer <[email protected]>
lan743x: fix for potential NULL pointer dereference with bare card
Filipe Manana <[email protected]>
btrfs: do not pin logs too early during renames
Filipe Manana <[email protected]>
btrfs: unify lookup return value when dir entry is missing
Marcos Paulo de Souza <[email protected]>
btrfs: introduce btrfs_lookup_match_dir
Josef Bacik <[email protected]>
btrfs: tree-checker: check for overlapping extent items
Borislav Petkov <[email protected]>
task_stack, x86/cea: Force-inline stack helpers
Andy Shevchenko <[email protected]>
ASoC: Intel: bytcr_rt5651: Drop reference count of ACPI device after use
Pierre-Louis Bossart <[email protected]>
ASoC: Intel: boards: get codec device with ACPI instead of bus search
Pierre-Louis Bossart <[email protected]>
ASoC: Intel: boards: harden codec property handling
YouChing Lin <[email protected]>
mtd: spinand: macronix: Add support for MX35LFxGE4AD
Shyam Prasad N <[email protected]>
cifs: add a warning when the in-flight count goes negative
Benjamin Gray <[email protected]>
powerpc/watchpoints: Annotate atomic context in more places
Ravi Bangoria <[email protected]>
powerpc/watchpoint: Workaround P10 DD1 issue with VSX-32 byte instructions
Michael Schmitz <[email protected]>
block: ataflop: fix breakage introduced at blk-mq refactoring
Kees Cook <[email protected]>
seccomp: Invalidate seccomp mode to catch death failures
Peter Zijlstra <[email protected]>
x86/uaccess: Implement macros for CMPXCHG on user addresses
Sebastian Andrzej Siewior <[email protected]>
hsr: Avoid double remove of a node.
Roger Pau Monne <[email protected]>
hvc/xen: prevent concurrent accesses to the shared ring
Dan Carpenter <[email protected]>
media: av7110: prevent underflow in write_ts_to_decoder()
Shengjiu Wang <[email protected]>
ASoC: fsl_micfil: register platform component before registering cpu dai
Xiaolei Wang <[email protected]>
ARM: dts: imx: Set default tuning step for imx6sx usdhc
Jiaxun Yang <[email protected]>
irqchip/mips-gic: Don't touch vl_map if a local interrupt is not routable
Rafał Miłecki <[email protected]>
ARM: dts: BCM53573: Drop nonexistent "default-off" LED trigger
Geert Uytterhoeven <[email protected]>
pmdomain: renesas: r8a77980-sysc: CR7 must be always on
Yi Sun <[email protected]>
virtio-blk: Ensure no requests in virtqueues before deleting vqs.
Takashi Sakamoto <[email protected]>
firewire: core: send bus reset promptly on gap count error
Hannes Reinecke <[email protected]>
scsi: lpfc: Use unsigned type for num_sge
Zhang Rui <[email protected]>
hwmon: (coretemp) Enlarge per package core count limit
Andrew Bresticker <[email protected]>
efi: Don't add memblocks for soft-reserved memory
Andrew Bresticker <[email protected]>
efi: runtime: Fix potential overflow of soft-reserved region size
Szilard Fabian <[email protected]>
Input: i8042 - add Fujitsu Lifebook U728 to i8042 quirk table
Zhang Yi <[email protected]>
ext4: correct the hole length returned by ext4_map_blocks()
Daniel Wagner <[email protected]>
nvmet-fc: abort command when there is no binding
Daniel Wagner <[email protected]>
nvmet-fc: release reference on target port
Daniel Wagner <[email protected]>
nvmet-fcloop: swap the list_add_tail arguments
Daniel Wagner <[email protected]>
nvme-fc: do not wait in vain when unloading module
Xin Long <[email protected]>
netfilter: conntrack: check SCTP_CID_SHUTDOWN_ACK for vtag setting in sctp_new
Wolfram Sang <[email protected]>
spi: sh-msiof: avoid integer overflow in constants
Chen-Yu Tsai <[email protected]>
ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616
Guixin Liu <[email protected]>
nvmet-tcp: fix nvme tcp ida memory leak
Martin Blumenstingl <[email protected]>
regulator: pwm-regulator: Add validity checks in continuous .get_voltage
Kunwu Chan <[email protected]>
dmaengine: ti: edma: Add some null pointer checks to the edma_probe
Baokun Li <[email protected]>
ext4: avoid allocating blocks from corrupted group in ext4_mb_find_by_goal()
Baokun Li <[email protected]>
ext4: avoid allocating blocks from corrupted group in ext4_mb_try_best_found()
Lennert Buytenhek <[email protected]>
ahci: add 43-bit DMA address quirk for ASMedia ASM1061 controllers
Conrad Kostecki <[email protected]>
ahci: asm1166: correct count of reported ports
Devyn Liu <[email protected]>
spi: hisi-sfc-v3xx: Return IRQ_NONE if no interrupts were detected
Fullway Wang <[email protected]>
fbdev: sis: Error out if pixclock equals zero
Fullway Wang <[email protected]>
fbdev: savage: Error out if pixclock equals zero
Felix Fietkau <[email protected]>
wifi: mac80211: fix race condition on enabling fast-xmit
Michal Kazior <[email protected]>
wifi: cfg80211: fix missing interfaces when dumping
Vinod Koul <[email protected]>
dmaengine: fsl-qdma: increase size of 'irq_name'
Vinod Koul <[email protected]>
dmaengine: shdma: increase size of 'dev_id'
Dmitry Bogdanov <[email protected]>
scsi: target: core: Add TMF to tmr_list handling
Cyril Hrubis <[email protected]>
sched/rt: Disallow writing invalid values to sched_rt_period_us
Cyril Hrubis <[email protected]>
sched/rt: Fix sysctl_sched_rr_timeslice intial value
Damien Le Moal <[email protected]>
zonefs: Improve error handling
Lokesh Gidra <[email protected]>
userfaultfd: fix mmap_changing checking in mfill_atomic_hugetlb
Cyril Hrubis <[email protected]>
sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset
Paulo Alcantara <[email protected]>
smb: client: fix parsing of SMB3.1.1 POSIX create context
Paulo Alcantara <[email protected]>
smb: client: fix potential OOBs in smb2_parse_contexts()
Paulo Alcantara <[email protected]>
smb: client: fix OOB in receive_encrypted_standard()
Jamal Hadi Salim <[email protected]>
net/sched: Retire dsmark qdisc
Jamal Hadi Salim <[email protected]>
net/sched: Retire ATM qdisc
Jamal Hadi Salim <[email protected]>
net/sched: Retire CBQ qdisc
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts | 1 -
arch/arm/boot/dts/bcm47189-luxul-xap-810.dts | 2 -
arch/arm/boot/dts/imx6sx.dtsi | 6 +
arch/arm/mach-ep93xx/core.c | 1 +
arch/arm64/boot/dts/rockchip/px30.dtsi | 2 +
arch/arm64/kvm/vgic/vgic-its.c | 5 +
arch/powerpc/kernel/hw_breakpoint.c | 76 +-
arch/s390/pci/pci.c | 2 +-
arch/x86/include/asm/cpu_entry_area.h | 2 +-
arch/x86/include/asm/nospec-branch.h | 2 +
arch/x86/include/asm/text-patching.h | 46 +-
arch/x86/include/asm/uaccess.h | 142 ++
arch/x86/kernel/alternative.c | 13 +-
arch/x86/kernel/ftrace.c | 4 +-
arch/x86/kernel/paravirt.c | 22 +-
arch/x86/kernel/static_call.c | 2 +-
arch/x86/net/bpf_jit_comp.c | 2 +-
drivers/ata/ahci.c | 34 +-
drivers/ata/ahci.h | 1 +
drivers/block/ataflop.c | 56 +-
drivers/block/virtio_blk.c | 7 +-
drivers/dma/fsl-qdma.c | 2 +-
drivers/dma/sh/shdma.h | 2 +-
drivers/dma/ti/edma.c | 10 +
drivers/firewire/core-card.c | 18 +-
drivers/firmware/efi/arm-runtime.c | 2 +-
drivers/firmware/efi/efi-init.c | 19 +-
drivers/firmware/efi/riscv-runtime.c | 2 +-
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
drivers/gpu/drm/drm_syncobj.c | 16 +-
drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c | 8 +-
drivers/hwmon/coretemp.c | 2 +-
drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 +-
drivers/infiniband/hw/hfi1/pio.c | 6 +-
drivers/infiniband/hw/hfi1/sdma.c | 2 +-
drivers/infiniband/hw/qedr/verbs.c | 11 +-
drivers/infiniband/ulp/srpt/ib_srpt.c | 17 +-
drivers/input/serio/i8042-acpipnpio.h | 8 +
drivers/irqchip/irq-mips-gic.c | 2 +
drivers/md/dm-crypt.c | 6 +
drivers/media/pci/ttpci/av7110_av.c | 4 +-
drivers/mtd/nand/spi/macronix.c | 20 +
drivers/net/ethernet/microchip/lan743x_ethtool.c | 9 +-
drivers/net/gtp.c | 10 +-
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 14 +-
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 10 +-
drivers/nvme/host/fc.c | 47 +-
drivers/nvme/target/fc.c | 11 +-
drivers/nvme/target/fcloop.c | 6 +-
drivers/nvme/target/tcp.c | 1 +
drivers/pci/msi.c | 2 +-
drivers/platform/x86/intel-vbtn.c | 6 +
drivers/regulator/pwm-regulator.c | 3 +
drivers/s390/cio/device_ops.c | 6 +-
drivers/scsi/Kconfig | 2 +-
drivers/scsi/lpfc/lpfc_scsi.c | 12 +-
drivers/soc/renesas/r8a77980-sysc.c | 3 +-
drivers/spi/spi-hisi-sfc-v3xx.c | 5 +
drivers/spi/spi-sh-msiof.c | 16 +-
drivers/target/target_core_device.c | 5 -
drivers/target/target_core_transport.c | 4 +
drivers/tty/hvc/hvc_xen.c | 19 +-
drivers/usb/cdns3/gadget.c | 8 +-
drivers/usb/gadget/function/f_ncm.c | 10 +-
drivers/usb/roles/class.c | 29 +-
drivers/video/fbdev/savage/savagefb_driver.c | 3 +
drivers/video/fbdev/sis/sis_main.c | 2 +
fs/afs/volume.c | 4 +-
fs/aio.c | 9 +-
fs/btrfs/ctree.h | 2 +-
fs/btrfs/dir-item.c | 122 +-
fs/btrfs/inode.c | 48 +-
fs/btrfs/tree-checker.c | 25 +-
fs/btrfs/tree-log.c | 14 +-
fs/cifs/smb2ops.c | 19 +-
fs/cifs/smb2pdu.c | 95 +-
fs/cifs/smb2proto.h | 12 +-
fs/erofs/decompressor.c | 24 +-
fs/ext4/extents.c | 111 +-
fs/ext4/mballoc.c | 33 +-
fs/jbd2/checkpoint.c | 137 +-
fs/zonefs/super.c | 68 +-
include/linux/fs.h | 2 +
include/linux/lockdep.h | 5 +
include/linux/sched/task_stack.h | 2 +-
include/linux/socket.h | 5 +-
include/net/tcp.h | 2 +-
kernel/sched/rt.c | 10 +-
kernel/seccomp.c | 10 +
kernel/sysctl.c | 4 +
mm/userfaultfd.c | 14 +-
net/core/dev.c | 2 +-
net/core/dev_ioctl.c | 2 +-
net/hsr/hsr_framereg.c | 16 +-
net/hsr/hsr_framereg.h | 1 +
net/ipv4/arp.c | 3 +-
net/ipv4/devinet.c | 21 +-
net/ipv6/addrconf.c | 21 +-
net/ipv6/seg6.c | 20 +-
net/l2tp/l2tp_ip6.c | 2 +-
net/mac80211/sta_info.c | 2 +
net/mac80211/tx.c | 2 +-
net/mptcp/diag.c | 6 +-
net/netfilter/nf_conntrack_proto_sctp.c | 2 +-
net/netfilter/nf_tables_api.c | 1 +
net/packet/af_packet.c | 12 +-
net/sched/Kconfig | 42 -
net/sched/Makefile | 3 -
net/sched/sch_atm.c | 709 --------
net/sched/sch_cbq.c | 1816 ---------------------
net/sched/sch_dsmark.c | 521 ------
net/tls/tls_main.c | 2 +-
net/tls/tls_sw.c | 12 +-
net/wireless/nl80211.c | 1 +
scripts/bpf_helpers_doc.py | 2 +-
sound/soc/fsl/fsl_micfil.c | 15 +-
sound/soc/intel/boards/bytcht_es8316.c | 14 +-
sound/soc/intel/boards/bytcr_rt5640.c | 46 +-
sound/soc/intel/boards/bytcr_rt5651.c | 41 +-
sound/soc/sunxi/sun4i-spdif.c | 5 +
123 files changed, 1267 insertions(+), 3694 deletions(-)
Hello!
On 27/02/24 7:26 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.211 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
We're seeing new warnings on 32-bits architectures: Arm, i386, PowerPC, RISC-V and System/390:
-----8<-----
builds/linux/net/ipv4/arp.c: In function 'arp_req_get':
/builds/linux/include/linux/minmax.h:20:35: warning: comparison of distinct pointer types lacks a cast
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
/builds/linux/include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
/builds/linux/include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
/builds/linux/include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
45 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
/builds/linux/net/ipv4/arp.c:1108:32: note: in expansion of macro 'min'
1108 | min(dev->addr_len, sizeof(r->arp_ha.sa_data_min)));
| ^~~
----->8-----
Bisection points to:
commit 5a2d57992eca13530ac79ae287243b3ff6b01128
Author: Kuniyuki Iwashima <[email protected]>
Date: Thu Feb 15 15:05:16 2024 -0800
arp: Prevent overflow in arp_req_get().
commit a7d6027790acea24446ddd6632d394096c0f4667 upstream.
Tuxmake reproducers:
tuxmake --runtime podman --target-arch arm --toolchain gcc-12 --kconfig davinci_all_defconfig
tuxmake --runtime podman --target-arch i386 --toolchain gcc-12 --kconfig defconfig
tuxmake --runtime podman --target-arch powerpc --toolchain gcc-12 --kconfig maple_defconfig
tuxmake --runtime podman --target-arch riscv --toolchain gcc-12 --kconfig defconfig
Reverting the change made the build pass again without warnings.
Reported-by: Linux Kernel Functional Testing <[email protected]>
Greetings!
Daniel Díaz
[email protected]
On 2/27/24 10:56, Daniel Díaz wrote:
> Hello!
>
> On 27/02/24 7:26 a. m., Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.211 release.
>> There are 122 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> We're seeing new warnings on 32-bits architectures: Arm, i386, PowerPC,
> RISC-V and System/390:
Seeing the same thing here.
--
Florian
On 2/27/24 05:26, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.211 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <[email protected]>
Same warning as what Daniel reported for ARM 32-bit:
In file included from ./include/linux/kernel.h:15,
from ./include/linux/list.h:9,
from ./include/linux/module.h:12,
from net/ipv4/arp.c:74:
net/ipv4/arp.c: In function 'arp_req_get':
/include/linux/minmax.h:20:35: warning: comparison of distinct pointer
types lacks a cast
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
/include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
/include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
/include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
45 | #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
net/ipv4/arp.c:1108:32: note: in expansion of macro 'min'
1108 | min(dev->addr_len,
sizeof(r->arp_ha.sa_data_min)));
| ^~~
--
Florian
Greg Kroah-Hartman wrote on Tue, Feb 27, 2024 at 02:26:01PM +0100:
> Kees Cook <[email protected]>
> net: dev: Convert sa_data to flexible array in struct sockaddr
> (ca13c2b1e9e4b5d982c2f1e75f28b1586e5c0f7f in this tree,
> b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 upstream)
This commit breaks build of some 3rd party wireless module we use here
(because sizeof(sa->sa_data) no longer works and needs to use
sa_data_min)
With that said I guess it really is a dependency on the arp_req_get
overflow, so probably necessary evil, and I don't think we explicitly
pretend to preserve APIs for 3rd party modules so this is probably
fine... The new warnings that poped up (and were reported in other
messages) a probably worth checking though.
That aside no particular problem actually running this, so--
Tested 5d69d611e74d ("Linux 5.10.211-rc1") on:
- arm i.MX6ULL (Armadillo 640)
- arm64 i.MX8MP (Armadillo G4)
No obvious regression in dmesg or basic tests:
Tested-by: Dominique Martinet <[email protected]>
--
Dominique Martinet | Asmadeus
On Tue, Feb 27, 2024 at 12:56:00PM -0600, Daniel D?az wrote:
> Hello!
>
> On 27/02/24 7:26 a.?m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.211 release.
> > There are 122 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> We're seeing new warnings on 32-bits architectures: Arm, i386, PowerPC, RISC-V and System/390:
>
> -----8<-----
> builds/linux/net/ipv4/arp.c: In function 'arp_req_get':
> /builds/linux/include/linux/minmax.h:20:35: warning: comparison of distinct pointer types lacks a cast
> 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> | ^~
> /builds/linux/include/linux/minmax.h:26:18: note: in expansion of macro '__typecheck'
> 26 | (__typecheck(x, y) && __no_side_effects(x, y))
> | ^~~~~~~~~~~
> /builds/linux/include/linux/minmax.h:36:31: note: in expansion of macro '__safe_cmp'
> 36 | __builtin_choose_expr(__safe_cmp(x, y), \
> | ^~~~~~~~~~
> /builds/linux/include/linux/minmax.h:45:25: note: in expansion of macro '__careful_cmp'
> 45 | #define min(x, y) __careful_cmp(x, y, <)
> | ^~~~~~~~~~~~~
> /builds/linux/net/ipv4/arp.c:1108:32: note: in expansion of macro 'min'
> 1108 | min(dev->addr_len, sizeof(r->arp_ha.sa_data_min)));
> | ^~~
> ----->8-----
>
> Bisection points to:
>
> commit 5a2d57992eca13530ac79ae287243b3ff6b01128
> Author: Kuniyuki Iwashima <[email protected]>
> Date: Thu Feb 15 15:05:16 2024 -0800
>
> arp: Prevent overflow in arp_req_get().
> commit a7d6027790acea24446ddd6632d394096c0f4667 upstream.
Ugh, I fixed this up for 5.15, but forgot to do so for older kernels, my
fault. I'll go update it now.
thanks,
greg k-h
On Wed, Feb 28, 2024 at 08:59:36AM +0900, Dominique Martinet wrote:
> Greg Kroah-Hartman wrote on Tue, Feb 27, 2024 at 02:26:01PM +0100:
> > Kees Cook <[email protected]>
> > net: dev: Convert sa_data to flexible array in struct sockaddr
> > (ca13c2b1e9e4b5d982c2f1e75f28b1586e5c0f7f in this tree,
> > b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 upstream)
>
> This commit breaks build of some 3rd party wireless module we use here
> (because sizeof(sa->sa_data) no longer works and needs to use
> sa_data_min)
> With that said I guess it really is a dependency on the arp_req_get
> overflow, so probably necessary evil, and I don't think we explicitly
> pretend to preserve APIs for 3rd party modules so this is probably
> fine... The new warnings that poped up (and were reported in other
> messages) a probably worth checking though.
We NEVER preserve in-kernel APIs for any out-of-tree code as obviously,
we have no idea what out-of-tree code is actually using, so it would be
impossible to do so.
Also, it's odd that a driver is hit by this as no in-kernel driver was,
so perhaps it's using the wrong api to start with :)
thanks,
greg k-h
On Tue, 27 Feb 2024 14:26:01 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.211 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
68 tests: 68 pass, 0 fail
Linux version: 5.10.211-rc1-g5d69d611e74d
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by: Jon Hunter <[email protected]>
Jon
On Wed, Feb 28, 2024 at 07:06:38AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 28, 2024 at 08:59:36AM +0900, Dominique Martinet wrote:
> > Greg Kroah-Hartman wrote on Tue, Feb 27, 2024 at 02:26:01PM +0100:
> > > Kees Cook <[email protected]>
> > > net: dev: Convert sa_data to flexible array in struct sockaddr
> > > (ca13c2b1e9e4b5d982c2f1e75f28b1586e5c0f7f in this tree,
> > > b5f0de6df6dce8d641ef58ef7012f3304dffb9a1 upstream)
> >
> > This commit breaks build of some 3rd party wireless module we use here
> > (because sizeof(sa->sa_data) no longer works and needs to use
> > sa_data_min)
Just FYI, it's possible that things using sizeof(sa->sa_data) were buggy
to begin with since the struct size isn't actually dictated by that size
(it's only the minimum possible size).
> > With that said I guess it really is a dependency on the arp_req_get
> > overflow, so probably necessary evil, and I don't think we explicitly
> > pretend to preserve APIs for 3rd party modules so this is probably
> > fine... The new warnings that poped up (and were reported in other
> > messages) a probably worth checking though.
>
> We NEVER preserve in-kernel APIs for any out-of-tree code as obviously,
> we have no idea what out-of-tree code is actually using, so it would be
> impossible to do so.
>
> Also, it's odd that a driver is hit by this as no in-kernel driver was,
> so perhaps it's using the wrong api to start with :)
The reason is that most drivers don't want this size (see above) and
all the in-tree code that did need adjustment got adjusted (visible in
the referenced patch). :) But that's the risk of an out-of-tree driver:
it doesn't get those fixes automatically.
Out of curiosity, which drivers broke and what's needed to get them into
upstream (or at least staging)?
-Kees
--
Kees Cook
Kees Cook wrote on Wed, Feb 28, 2024 at 12:39:42PM -0800:
> > > This commit breaks build of some 3rd party wireless module we use here
> > > (because sizeof(sa->sa_data) no longer works and needs to use
> > > sa_data_min)
>
> Just FYI, it's possible that things using sizeof(sa->sa_data) were buggy
> to begin with since the struct size isn't actually dictated by that size
> (it's only the minimum possible size).
Yes, I definitely agree with this.
As it's "vendor stuff" I just replaced with sa_data_min because that
preserves the values, but it ought to get a second look.
I'd love to pretend that driver's upstream will do the right thing and
use proper values here on newer kernel but upon checking its >6.2 tree
support now they apparently did the same instead of getting the size
properly.
> > We NEVER preserve in-kernel APIs for any out-of-tree code as obviously,
> > we have no idea what out-of-tree code is actually using, so it would be
> > impossible to do so.
Right, I just don't see much "common struct" changes in stable tree
patches -- stuff like livepatches or weak modules and whatsnot don't
like these so some downstreams (redhat to name them) try very hard to
keep these constants for the lifetime of a given stable release... iirc
they go as far as adding some padding fields to some structs that are
likely to need fiddling so they can do this while preserving binary
compatibility.
I understand the upstream stable kernels don't make such promise (and
given the amount of work that probably goes into it, rightfully so! I
wouldn't exect you or anyone to do this here), just pointed it out
as part of my usual test round for anyone else who'd care.
> Out of curiosity, which drivers broke and what's needed to get them into
> upstream (or at least staging)?
Sure, it was NXP's wifi chips driver:
https://github.com/nxp-imx/mwifiex/
It's mostly based on drivers/net/wireless/marvell/mwifiex but has since
been quite extensively modified, so it'd take quite a bit of effort to
upstream as a separate entity (changing a few names to avoid conflcts so
both can be built together... Add to that the requirement for a
compatible firmware with a restrictive license... And that NXP isn't
exactly focused on upstreaming); I have little hope of seeing it
upstream at this point unfortunately and gave up on it as part of
maintaining an embedded kernel "port" as it's sadly far from being
only one :/
(I especially don't get it as I consider maintaining a bunch of
spaghetti ifdef on kernel versions to be much more work than getting the
driver upstream once, but I guess I'm barking at the wrong tree here)
Thanks,
--
Dominique Martinet | Asmadeus
On Tuesday, February 27, 2024 18:56 IST, Greg Kroah-Hartman <[email protected]> wrote:
> This is the start of the stable review cycle for the 5.10.211 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 29 Feb 2024 13:15:36 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.211-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rcgit linux-5.10.y
> and the diffstat can be found below.
>
KernelCI report for stable-rc/linux-5.10.y for this week.
## stable-rc HEAD for linux-5.10.y:
Date: 2024-02-27
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/log/?h=5d69d611e74dd9f58af23f171ccd3405a650c6ed
## Build failures:
No build failures seen for the stable-rc/linux-5.10.y commit head \o/
## Boot failures:
No **new** boot failures seen for the stable-rc/linux-5.10.y commit head \o/
Tested-by: kernelci.org bot <[email protected]>
Thanks,
Shreeya Patel
Hi!
> This is the start of the stable review cycle for the 5.10.211 release.
> There are 122 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel Machek (CIP) <[email protected]>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany