2023-06-23 06:20:35

by Baruch Siach

Subject: [PATCH RESEND] binfmt_elf: fix comment typo s/reset/regset/

Signed-off-by: Baruch Siach <[email protected]>
---

Resending with LKML in Cc. kvack.org MX does not like our mail server.
---
fs/binfmt_elf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git fs/binfmt_elf.c fs/binfmt_elf.c
index 8a884e795f6a..f304a3434c5a 100644
--- fs/binfmt_elf.c
+++ fs/binfmt_elf.c
@@ -1773,7 +1773,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
/*
* NT_PRSTATUS is the one special case, because the regset data
* goes into the pr_reg field inside the note contents, rather
- * than being the whole note contents. We fill the reset in here.
+ * than being the whole note contents. We fill the regset in here.
* We assume that regset 0 is NT_PRSTATUS.
*/
fill_prstatus(&t->prstatus.common, t->task, signr);
--
2.40.1

2023-06-23 17:12:18

by Kees Cook

Subject: Re: [PATCH RESEND] binfmt_elf: fix comment typo s/reset/regset/

On Fri, Jun 23, 2023 at 08:56:44AM +0300, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <[email protected]>
> ---
>
> Resending with LKML in Cc. kvack.org MX does not like our mail server.
> ---
> fs/binfmt_elf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git fs/binfmt_elf.c fs/binfmt_elf.c
> index 8a884e795f6a..f304a3434c5a 100644
> --- fs/binfmt_elf.c
> +++ fs/binfmt_elf.c

Same formatting issue with this one.

> @@ -1773,7 +1773,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
> /*
> * NT_PRSTATUS is the one special case, because the regset data
> * goes into the pr_reg field inside the note contents, rather
> - * than being the whole note contents. We fill the reset in here.
> + * than being the whole note contents. We fill the regset in here.
> * We assume that regset 0 is NT_PRSTATUS.
> */
> fill_prstatus(&t->prstatus.common, t->task, signr);

But thank you; I've applied both to the execve tree:

https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/execve

-Kees

--
Kees Cook