2022-01-07 18:04:31

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module

From: Marcel Ziswiler <[email protected]>

Build Realtek Gigabit Ethernet driver as a module.

Signed-off-by: Marcel Ziswiler <[email protected]>
---

arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a18785a827dc..86d39d8456c1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -338,6 +338,7 @@ CONFIG_MLX5_CORE=m
CONFIG_MLX5_CORE_EN=y
CONFIG_QCOM_EMAC=m
CONFIG_RMNET=m
+CONFIG_R8169=m
CONFIG_SH_ETH=y
CONFIG_RAVB=y
CONFIG_SMC91X=y
--
2.33.1



2022-01-10 08:42:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module

On 07/01/2022 19:03, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Build Realtek Gigabit Ethernet driver as a module.

Why?

We see what the patch does easily, so no really need of explaining it.
What is needed here is to explain why do you do it? What board needs it?

>
> Signed-off-by: Marcel Ziswiler <[email protected]>
> ---
>
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a18785a827dc..86d39d8456c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -338,6 +338,7 @@ CONFIG_MLX5_CORE=m
> CONFIG_MLX5_CORE_EN=y
> CONFIG_QCOM_EMAC=m
> CONFIG_RMNET=m
> +CONFIG_R8169=m
> CONFIG_SH_ETH=y
> CONFIG_RAVB=y
> CONFIG_SMC91X=y
>


Best regards,
Krzysztof

2022-01-14 13:25:54

by Marcel Ziswiler

[permalink] [raw]
Subject: Re: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module

On Mon, 2022-01-10 at 09:40 +0100, Krzysztof Kozlowski wrote:
> On 07/01/2022 19:03, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <[email protected]>
> >
> > Build Realtek Gigabit Ethernet driver as a module.
>
> Why?
>
> We see what the patch does easily, so no really need of explaining it.
> What is needed here is to explain why do you do it? What board needs it?

Yes, I will do so in v2. Thanks!

[snip]
> Best regards,
> Krzysztof

Cheers

Marcel