2019-11-15 13:13:06

by Yue Haibing

Subject: [PATCH -next] x86/efi: remove unused variables

commit ad723674d675 ("x86/efi: move common keyring
handler functions to new file") leave this unused.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
security/integrity/platform_certs/load_uefi.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
index 4369204..111898a 100644
--- a/security/integrity/platform_certs/load_uefi.c
+++ b/security/integrity/platform_certs/load_uefi.c
@@ -11,11 +11,6 @@
#include "../integrity.h"
#include "keyring_handler.h"

-static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
-static efi_guid_t efi_cert_x509_sha256_guid __initdata =
- EFI_CERT_X509_SHA256_GUID;
-static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
-
/*
* Look to see if a UEFI variable called MokIgnoreDB exists and return true if
* it does.
--
2.7.4

2019-11-29 12:10:41

by Michael Ellerman

Subject: Re: [PATCH -next] x86/efi: remove unused variables

YueHaibing <[email protected]> writes:
> commit ad723674d675 ("x86/efi: move common keyring
> handler functions to new file") leave this unused.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> security/integrity/platform_certs/load_uefi.c | 5 -----
> 1 file changed, 5 deletions(-)

Thanks for spotting this, my x86 test builds did trigger it, but I
didn't notice the new warnings.

I've picked this up into the powerpc tree, as that's where the offending
commit is.

cheers

> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index 4369204..111898a 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -11,11 +11,6 @@
> #include "../integrity.h"
> #include "keyring_handler.h"
>
> -static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
> -static efi_guid_t efi_cert_x509_sha256_guid __initdata =
> - EFI_CERT_X509_SHA256_GUID;
> -static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
> -
> /*
> * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
> * it does.
> --
> 2.7.4

2019-12-02 14:40:15

by Nayna Jain

Subject: Re: [PATCH -next] x86/efi: remove unused variables

On 11/15/19 8:08 AM, YueHaibing wrote:
> commit ad723674d675 ("x86/efi: move common keyring
> handler functions to new file") leave this unused.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> security/integrity/platform_certs/load_uefi.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index 4369204..111898a 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -11,11 +11,6 @@
> #include "../integrity.h"
> #include "keyring_handler.h"
>
> -static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
> -static efi_guid_t efi_cert_x509_sha256_guid __initdata =
> - EFI_CERT_X509_SHA256_GUID;
> -static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
> -
> /*
> * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
> * it does.


Thanks for noticing and fixing this.

Thanks & Regards,

     - Nayna