2020-03-26 21:24:39

by Alain Volmat

[permalink] [raw]
Subject: [PATCH] i2c: i2c-st: fix missing struct parameter description

Fix a missing struct parameter description to allow
warning free W=1 compilation.

Signed-off-by: Alain Volmat <[email protected]>
---
drivers/i2c/busses/i2c-st.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 54e1fc8a495e..f7f7b5b64720 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -434,6 +434,7 @@ static void st_i2c_wr_fill_tx_fifo(struct st_i2c_dev *i2c_dev)
/**
* st_i2c_rd_fill_tx_fifo() - Fill the Tx FIFO in read mode
* @i2c_dev: Controller's private data
+ * @max: Maximum amount of data to fill into the Tx FIFO
*
* This functions fills the Tx FIFO with fixed pattern when
* in read mode to trigger clock.
--
2.17.1


2020-03-27 08:48:18

by Patrice CHOTARD

[permalink] [raw]
Subject: Re: [PATCH] i2c: i2c-st: fix missing struct parameter description

Hi Alain

On 3/26/20 10:22 PM, Alain Volmat wrote:
> Fix a missing struct parameter description to allow
> warning free W=1 compilation.
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> drivers/i2c/busses/i2c-st.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index 54e1fc8a495e..f7f7b5b64720 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -434,6 +434,7 @@ static void st_i2c_wr_fill_tx_fifo(struct st_i2c_dev *i2c_dev)
> /**
> * st_i2c_rd_fill_tx_fifo() - Fill the Tx FIFO in read mode
> * @i2c_dev: Controller's private data
> + * @max: Maximum amount of data to fill into the Tx FIFO
> *
> * This functions fills the Tx FIFO with fixed pattern when
> * in read mode to trigger clock.

Reviewed-by: Patrice Chotard <[email protected]>

Thanks

2020-03-28 04:04:50

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: i2c-st: fix missing struct parameter description

On Thu, Mar 26, 2020 at 10:22:43PM +0100, Alain Volmat wrote:
> Fix a missing struct parameter description to allow
> warning free W=1 compilation.
>
> Signed-off-by: Alain Volmat <[email protected]>

Applied to for-current, thanks! Please note that the 'i2c-' prefix of
the driver is dropped because it is redundant in $ubject.


Attachments:
(No filename) (337.00 B)
signature.asc (849.00 B)
Download all attachments