2022-11-21 05:20:36

by Yong Wu (吴勇)

[permalink] [raw]
Subject: Re: [PATCH v4 1/4] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

On Tue, 2022-10-18 at 14:42 +0800, Chengci.Xu wrote:
> Adds descriptions for mt8188 IOMMU which also use ARM Short-
> Descriptor
> translation table format.
>
> In mt8188, there are two smi-common HW and IOMMU, one is for
> vdo(video
> output), the other is for vpp(video processing pipe). They connects
> with different smi-larbs, then some setting(larbid_remap) is
> different.
> Differentiate them with the compatible string.
>
> Something like this:
>
> IOMMU(VDO) IOMMU(VPP)
> | |
> SMI_COMMON_VDO SMI_COMMON_VPP
> --------------- ----------------
> | | ... | | ...
> larb0 larb2 ... larb1 larb3 ...
>
> We also have an IOMMU that is for infra master like PCIe.
> And infra master don't have the larb and ports.
>
> Signed-off-by: Chengci.Xu <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/iommu/mediatek,iommu.yaml | 12 +-
> .../memory/mediatek,mt8188-memory-port.h | 482
> ++++++++++++++++++

Reviewed-by: Yong Wu <[email protected]>