2020-09-02 14:27:27

by Christoph Hellwig

Subject: [PATCH 11/19] gdrom: use bdev_check_media_change

The GD-ROM driver does not have a ->revalidate_disk method, so it can
just use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig <[email protected]>
---
drivers/cdrom/gdrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 09b0cd292720fa..9874fc1c815b53 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -479,7 +479,7 @@ static int gdrom_bdops_open(struct block_device *bdev, fmode_t mode)
{
int ret;

- check_disk_change(bdev);
+ bdev_check_media_change(bdev);

mutex_lock(&gdrom_mutex);
ret = cdrom_open(gd.cd_info, bdev, mode);
--
2.28.0

2020-09-02 15:46:46

by Johannes Thumshirn

Subject: Re: [PATCH 11/19] gdrom: use bdev_check_media_change

Looks good,
Reviewed-by: Johannes Thumshirn <[email protected]>

2020-09-02 22:01:24

by Wols Lists

Subject: Re: [PATCH 11/19] gdrom: use bdev_check_media_change

On 02/09/2020 15:12, Christoph Hellwig wrote:
> The GD-ROM driver does not have a ->revalidate_disk method, so it can
^^ (sic)

Cheers,
Wol

2020-09-08 14:51:25

by Christoph Hellwig

Subject: Re: [PATCH 11/19] gdrom: use bdev_check_media_change

On Wed, Sep 02, 2020 at 11:00:05PM +0100, antlists wrote:
> On 02/09/2020 15:12, Christoph Hellwig wrote:
>> The GD-ROM driver does not have a ->revalidate_disk method, so it can
> ^^ (sic)

No, this really is the GD-ROM and not the CD-ROM driver!