2020-01-08 00:51:56

by Edwin Zimmerman

Subject: [PATCH] x86/boot: fix cast to pointer compiler warning

Fix cast-to-pointer compiler warning

arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_srat_table’:
arch/x86/boot/compressed/acpi.c:316:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
        ^
Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
Signed-off-by: Edwin Zimmerman <[email protected]>
---
arch/x86/boot/compressed/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
index 25019d42ae93..5d2568066d58 100644
--- a/arch/x86/boot/compressed/acpi.c
+++ b/arch/x86/boot/compressed/acpi.c
@@ -313,7 +313,7 @@ static unsigned long get_acpi_srat_table(void)
* stash this in boot params because the kernel itself may have
* different ideas about whether to trust a command-line parameter.
*/
- rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
+ rsdp = (struct acpi_table_rsdp *)(long)get_cmdline_acpi_rsdp();
if (!rsdp)
rsdp = (struct acpi_table_rsdp *)(long)

--
2.17.1

2020-01-08 01:20:30

by Randy Dunlap

Subject: Re: [PATCH] x86/boot: fix cast to pointer compiler warning

On 1/7/20 9:38 PM, Edwin Zimmerman wrote:
> Fix cast-to-pointer compiler warning
>
> arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_srat_table’:
> arch/x86/boot/compressed/acpi.c:316:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>         ^
> Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
> Signed-off-by: Edwin Zimmerman <[email protected]>
> ---
> arch/x86/boot/compressed/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
> index 25019d42ae93..5d2568066d58 100644
> --- a/arch/x86/boot/compressed/acpi.c
> +++ b/arch/x86/boot/compressed/acpi.c
> @@ -313,7 +313,7 @@ static unsigned long get_acpi_srat_table(void)
> * stash this in boot params because the kernel itself may have
> * different ideas about whether to trust a command-line parameter.
> */
> - rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
> + rsdp = (struct acpi_table_rsdp *)(long)get_cmdline_acpi_rsdp();
> if (!rsdp)
> rsdp = (struct acpi_table_rsdp *)(long)
>

Lots of whitespace damage. Probably your email client or some
intermediary.

--
~Randy

2020-01-08 01:31:07

by Edwin Zimmerman

Subject: Re: [PATCH] x86/boot: fix cast to pointer compiler warning

On 1/7/2020 8:18 PM, Randy Dunlap wrote:
> On 1/7/20 9:38 PM, Edwin Zimmerman wrote:
>> Fix cast-to-pointer compiler warning
>>
>> arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_srat_table’:
>> arch/x86/boot/compressed/acpi.c:316:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>>         ^
>> Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
>> Signed-off-by: Edwin Zimmerman <[email protected]>
>> ---
>> arch/x86/boot/compressed/acpi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
>> index 25019d42ae93..5d2568066d58 100644
>> --- a/arch/x86/boot/compressed/acpi.c
>> +++ b/arch/x86/boot/compressed/acpi.c
>> @@ -313,7 +313,7 @@ static unsigned long get_acpi_srat_table(void)
>> * stash this in boot params because the kernel itself may have
>> * different ideas about whether to trust a command-line parameter.
>> */
>> - rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>> + rsdp = (struct acpi_table_rsdp *)(long)get_cmdline_acpi_rsdp();
>> if (!rsdp)
>> rsdp = (struct acpi_table_rsdp *)(long)
>>
> Lots of whitespace damage. Probably your email client or some
> intermediary.
Email client, sorry.  Will resend.