2023-06-01 07:24:35

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: qdu1000: Add SDHCI pin configuration to DTSI

On 01/06/2023 08:58, Komal Bajaj wrote:
> Add required pins for SDHCI, so that the interface can work reliably.
>

This is not a separate commit. The pin configuration by itself does not
make sense and we don't need it. It's part of adding SDHCI, so squash it.

Best regards,
Krzysztof



2023-06-01 08:31:16

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: qdu1000: Add SDHCI pin configuration to DTSI



On 1.06.2023 09:00, Krzysztof Kozlowski wrote:
> On 01/06/2023 08:58, Komal Bajaj wrote:
>> Add required pins for SDHCI, so that the interface can work reliably.
>>
>
> This is not a separate commit. The pin configuration by itself does not
> make sense and we don't need it. It's part of adding SDHCI, so squash it.
keep my rb for the squashed patch

Konrad
>
> Best regards,
> Krzysztof
>

2023-06-01 08:55:29

by Komal Bajaj

[permalink] [raw]
Subject: Re: [PATCH v4 3/4] arm64: dts: qcom: qdu1000: Add SDHCI pin configuration to DTSI



On 6/1/2023 12:30 PM, Krzysztof Kozlowski wrote:
> On 01/06/2023 08:58, Komal Bajaj wrote:
>> Add required pins for SDHCI, so that the interface can work reliably.
>>
> This is not a separate commit. The pin configuration by itself does not
> make sense and we don't need it. It's part of adding SDHCI, so squash it.

Okay, will combine this patch with 2nd in the next patch series.

Thanks
Komal

>
> Best regards,
> Krzysztof
>