2023-07-27 09:47:17

by Lukasz Majewski

Subject: [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5

Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows
following device warning:

'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'

This is not critical, as KSZ driver by itself assigns default value of
tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).

However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps'
has been specified with the default value of 2000 ps.

Signed-off-by: Lukasz Majewski <[email protected]>
---
arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
index 99cd6d15998b..b66570080894 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
@@ -152,6 +152,7 @@
label = "cpu";
ethernet = <&macb0>;
phy-mode = "rgmii-txid";
+ tx-internal-delay-ps = <2000>;

fixed-link {
speed = <1000>;
--
2.20.1

2023-08-02 06:41:32

by claudiu beznea

Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5

On 27.07.2023 11:06, Lukasz Majewski wrote:
> Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows
> following device warning:
>
> 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'
>
> This is not critical, as KSZ driver by itself assigns default value of
> tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).
>
> However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps'
> has been specified with the default value of 2000 ps.
>
> Signed-off-by: Lukasz Majewski <[email protected]>

Applied to at91-dt, thanks!