Hi Pavel,
At 11/15/2017 03:57 AM, Pavel Tatashin wrote:
>> why we should remove the *extern* keyword?
>
> Hi Dou,
>
> While, I am not sure why it was decided to stop using externs in
> headers, this is a warning printed by scripts/checkpatch.pl:
>
> CHECK: extern prototypes should be avoided in .h files
>
> To have a clean checkpatch output I removed externs.
>
I see.
IMO, using the extern keyword on function prototypes in *.h files
is superfluous, but, It doesn't matter for functionality. *extern*
is default keywords.
AFAIK, it's a code style problem. In x86 arch, we prefer to
keep *extern* explicitly, so, let's keep it like before for
code consistency.
Thank,
dou
From 1584073337926067776@xxx Tue Nov 14 20:07:37 +0000 2017
X-GM-THRID: 1583556040265529206
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread