2018-01-12 22:08:35

by W. Trevor King

[permalink] [raw]
Subject: [PATCH] security/Kconfig: Remove pagetable-isolation.txt reference

The reference landed with the config option in 385ce0ea (x86/mm/pti:
Add Kconfig, 2017-12-04), but the referenced file was never committed.

Signed-off-by: W. Trevor King <[email protected]>
---
security/Kconfig | 2 --
1 file changed, 2 deletions(-)

diff --git a/security/Kconfig b/security/Kconfig
index 3d4debd0257e..6c02b69581c8 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -63,8 +63,6 @@ config PAGE_TABLE_ISOLATION
ensuring that the majority of kernel addresses are not mapped
into userspace.

- See Documentation/x86/pagetable-isolation.txt for more details.
-
config SECURITY_INFINIBAND
bool "Infiniband Security Hooks"
depends on SECURITY && INFINIBAND
--
2.13.6


2018-01-12 23:07:17

by James Morris

[permalink] [raw]
Subject: Re: [PATCH] security/Kconfig: Remove pagetable-isolation.txt reference

On Fri, 12 Jan 2018, W. Trevor King wrote:

> The reference landed with the config option in 385ce0ea (x86/mm/pti:
> Add Kconfig, 2017-12-04), but the referenced file was never committed.
>
> Signed-off-by: W. Trevor King <[email protected]>


Acked-by: James Morris <[email protected]>


--
James Morris
<[email protected]>

2018-01-12 23:10:58

by Dave Hansen

[permalink] [raw]
Subject: Re: [PATCH] security/Kconfig: Remove pagetable-isolation.txt reference

On 01/12/2018 03:06 PM, James Morris wrote:
> On Fri, 12 Jan 2018, W. Trevor King wrote:
>
>> The reference landed with the config option in 385ce0ea (x86/mm/pti:
>> Add Kconfig, 2017-12-04), but the referenced file was never committed.
>>
>> Signed-off-by: W. Trevor King <[email protected]>
>
> Acked-by: James Morris <[email protected]>

There is a new file in -tip:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/pti&id=01c9b17bf673b05bb401b76ec763e9730ccf1376

If you're going to patch this, please send an update to -tip that corrects the filename.

2018-01-12 23:27:11

by W. Trevor King

[permalink] [raw]
Subject: [PATCH] security/Kconfig: Replace pagetable-isolation.txt reference with pti.txt

The reference landed with the config option in 385ce0ea (x86/mm/pti:
Add Kconfig, 2017-12-04), but the referenced file was not committed
then. It eventually landed in 01c9b17b (x86/Documentation: Add PTI
description, 2018-01-05) as pti.txt.

Signed-off-by: W. Trevor King <[email protected]>
---
On Fri, Jan 12, 2018 at 03:10:53PM -0800, Dave Hansen wrote:
> There is a new file in -tip:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/pti&id=01c9b17bf673b05bb401b76ec763e9730ccf1376
>
> If you're going to patch this, please send an update to -tip that
> corrects the filename.

Here you go :).

Cheers,
Trevor

security/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/Kconfig b/security/Kconfig
index 3d4debd0257e..b0cb9a5f9448 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -63,7 +63,7 @@ config PAGE_TABLE_ISOLATION
ensuring that the majority of kernel addresses are not mapped
into userspace.

- See Documentation/x86/pagetable-isolation.txt for more details.
+ See Documentation/x86/pti.txt for more details.

config SECURITY_INFINIBAND
bool "Infiniband Security Hooks"
--
2.13.6

2018-01-13 01:19:35

by Dave Hansen

[permalink] [raw]
Subject: Re: [PATCH] security/Kconfig: Replace pagetable-isolation.txt reference with pti.txt

On 01/12/2018 03:24 PM, W. Trevor King wrote:
> The reference landed with the config option in 385ce0ea (x86/mm/pti:
> Add Kconfig, 2017-12-04), but the referenced file was not committed
> then. It eventually landed in 01c9b17b (x86/Documentation: Add PTI
> description, 2018-01-05) as pti.txt.
>
> Signed-off-by: W. Trevor King <[email protected]>
> ---
> On Fri, Jan 12, 2018 at 03:10:53PM -0800, Dave Hansen wrote:
>> There is a new file in -tip:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/pti&id=01c9b17bf673b05bb401b76ec763e9730ccf1376
>>
>> If you're going to patch this, please send an update to -tip that
>> corrects the filename.
>
> Here you go :).

Feel free to add my Acked-by. And please send to [email protected]. They
need to put this in after the addition of the documentation.

2018-01-13 05:59:42

by W. Trevor King

[permalink] [raw]
Subject: Re: [PATCH] security/Kconfig: Replace pagetable-isolation.txt reference with pti.txt

On Fri, Jan 12, 2018 at 05:19:32PM -0800, Dave Hansen wrote:
> On 01/12/2018 03:24 PM, W. Trevor King wrote:
> >> If you're going to patch this, please send an update to -tip that
> >> corrects the filename.
> >
> > Here you go :).
>
> Feel free to add my Acked-by. And please send to [email protected].
> They need to put this in after the addition of the documentation.

I've bounced my patch and your reply to [email protected] (although your
reply may not go through, I'm not sure what Intel has setup for
SPF/DMARC/…).

And this is a very small fix. If it's easier to just have somebody
with commit access to the appropriate feeder repo file the patch
wherever it needs to go, that's fine with me too.

Cheers,
Trevor

--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy


Attachments:
(No filename) (876.00 B)
signature.asc (833.00 B)
OpenPGP digital signature
Download all attachments
Subject: [tip:x86/pti] security/Kconfig: Correct the Documentation reference for PTI

Commit-ID: a237f762681e2a394ca67f21df2feb2b76a3609b
Gitweb: https://git.kernel.org/tip/a237f762681e2a394ca67f21df2feb2b76a3609b
Author: W. Trevor King <[email protected]>
AuthorDate: Fri, 12 Jan 2018 15:24:59 -0800
Committer: Thomas Gleixner <[email protected]>
CommitDate: Sun, 14 Jan 2018 11:42:10 +0100

security/Kconfig: Correct the Documentation reference for PTI

When the config option for PTI was added a reference to documentation was
added as well. But the documentation did not exist at that point. The final
documentation has a different file name.

Fix it up to point to the proper file.

Fixes: 385ce0ea ("x86/mm/pti: Add Kconfig")
Signed-off-by: W. Trevor King <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: James Morris <[email protected]>
Cc: "Serge E. Hallyn" <[email protected]>
Cc: [email protected]
Link: https://lkml.kernel.org/r/3009cc8ccbddcd897ec1e0cb6dda524929de0d14.1515799398.git.wking@tremily.us

---
security/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/Kconfig b/security/Kconfig
index 3d4debd..b0cb9a5 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -63,7 +63,7 @@ config PAGE_TABLE_ISOLATION
ensuring that the majority of kernel addresses are not mapped
into userspace.

- See Documentation/x86/pagetable-isolation.txt for more details.
+ See Documentation/x86/pti.txt for more details.

config SECURITY_INFINIBAND
bool "Infiniband Security Hooks"