2021-01-20 12:14:03

by Tero Kristo

[permalink] [raw]
Subject: Re: [PATCH 15/20] clk: ti: dpll: Fix misnaming of '_register_dpll()'s 'user' parameter

On 20/01/2021 11:30, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/ti/dpll.c:163: warning: Function parameter or member 'user' not described in '_register_dpll'
> drivers/clk/ti/dpll.c:163: warning: Excess function parameter 'hw' description in '_register_dpll'
>
> Cc: Tero Kristo <[email protected]>
> Cc: Michael Turquette <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>

Reviewed-by: Tero Kristo <[email protected]>

> ---
> drivers/clk/ti/dpll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c
> index 247510e306e2a..d6f1ac5b53e14 100644
> --- a/drivers/clk/ti/dpll.c
> +++ b/drivers/clk/ti/dpll.c
> @@ -151,7 +151,7 @@ static const struct clk_ops dpll_x2_ck_ops = {
>
> /**
> * _register_dpll - low level registration of a DPLL clock
> - * @hw: hardware clock definition for the clock
> + * @user: pointer to the hardware clock definition for the clock
> * @node: device node for the clock
> *
> * Finalizes DPLL registration process. In case a failure (clk-ref or
>