2021-08-29 10:11:01

by Denis Efremov (Oracle)

[permalink] [raw]
Subject: [GIT PULL] Floppy patch for 5.15

Hi Jens,

Sorry for the late PR this time. I'll resend it later if it's too late for
your for-5.15/drivers branch. Thanks.

The following changes since commit 461d971215dfb55bcd5f7d040b2b222592040f95:

Merge branch 'md-next' of https://git.kernel.org/pub/scm/linux/kernel/git/song/md into for-5.15/drivers (2021-08-27 16:32:01 -0600)

are available in the Git repository at:

https://github.com/evdenis/linux-floppy tags/floppy-for-5.15

for you to fetch changes up to c7e9d0020361f4308a70cdfd6d5335e273eb8717:

Revert "floppy: reintroduce O_NDELAY fix" (2021-08-28 11:16:47 +0300)

Please, pull

----------------------------------------------------------------
Bring back O_NDELAY for floppy

Only one commit this time with revert of O_NDELAY removal for the floppy.
Users reported that the commit breaks userspace utils and known floppy
workflow patterns. We already reverted the same commit back in 2016
presumably for the same reason. Completely drop O_NDELAY for floppy seems
excessive to solve problems it introduces.

I started to write basic selftests for the floppy to prevent this kind of
userspace breaks in the future.

Signed-off-by: Denis Efremov <[email protected]>

----------------------------------------------------------------
Denis Efremov (1):
Revert "floppy: reintroduce O_NDELAY fix"

drivers/block/floppy.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)


2021-08-29 12:54:16

by Jens Axboe

[permalink] [raw]
Subject: Re: [GIT PULL] Floppy patch for 5.15

On 8/29/21 4:08 AM, Denis Efremov wrote:
> Hi Jens,
>
> Sorry for the late PR this time. I'll resend it later if it's too late for
> your for-5.15/drivers branch. Thanks.

Given the patch in question, let's just do it. I've pulled it, thanks.

--
Jens Axboe