From: Frank Rowand <[email protected]>
Devicetree overlay notifiers have a chance to potentially get
pointers into the overlay unflattened devicetree and overlay FDT.
The only protection against these pointers being accessed after
the underlying data has been released by kfree() is by source
code review of patches. Add a keyword line to the devicetree
overlay maintainers entry to try to catch overlay notifier
related patches.
The keyword line is added to the devicetree overlay entry instead
of the devicetree entry so that not all maintainers will receive
the additional review traffic. Add Frank Rowand (already a
maintainer in the devicetree entry) so that he will receive
the additional review traffic.
Signed-off-by: Frank Rowand <[email protected]>
---
changes from version 1:
- removed extraneous "From:" tags at top of patch description
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 92be777d060a..aca3956694f8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10422,12 +10422,14 @@ F: drivers/infiniband/ulp/opa_vnic
OPEN FIRMWARE AND DEVICE TREE OVERLAYS
M: Pantelis Antoniou <[email protected]>
+M: Frank Rowand <[email protected]>
L: [email protected]
S: Maintained
F: Documentation/devicetree/dynamic-resolution-notes.txt
F: Documentation/devicetree/overlay-notes.txt
F: drivers/of/overlay.c
F: drivers/of/resolver.c
+K: of_overlay_notifier_
OPEN FIRMWARE AND FLATTENED DEVICE TREE
M: Rob Herring <[email protected]>
--
Frank Rowand <[email protected]>
Hi Rob,
Do you want to take this or should I route it through Andrew?
-Frank
On 04/27/18 18:31, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Devicetree overlay notifiers have a chance to potentially get
> pointers into the overlay unflattened devicetree and overlay FDT.
> The only protection against these pointers being accessed after
> the underlying data has been released by kfree() is by source
> code review of patches. Add a keyword line to the devicetree
> overlay maintainers entry to try to catch overlay notifier
> related patches.
>
> The keyword line is added to the devicetree overlay entry instead
> of the devicetree entry so that not all maintainers will receive
> the additional review traffic. Add Frank Rowand (already a
> maintainer in the devicetree entry) so that he will receive
> the additional review traffic.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
>
> changes from version 1:
> - removed extraneous "From:" tags at top of patch description
>
>
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92be777d060a..aca3956694f8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10422,12 +10422,14 @@ F: drivers/infiniband/ulp/opa_vnic
>
> OPEN FIRMWARE AND DEVICE TREE OVERLAYS
> M: Pantelis Antoniou <[email protected]>
> +M: Frank Rowand <[email protected]>
> L: [email protected]
> S: Maintained
> F: Documentation/devicetree/dynamic-resolution-notes.txt
> F: Documentation/devicetree/overlay-notes.txt
> F: drivers/of/overlay.c
> F: drivers/of/resolver.c
> +K: of_overlay_notifier_
>
> OPEN FIRMWARE AND FLATTENED DEVICE TREE
> M: Rob Herring <[email protected]>
>
On Fri, Apr 27, 2018 at 06:31:20PM -0700, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Devicetree overlay notifiers have a chance to potentially get
> pointers into the overlay unflattened devicetree and overlay FDT.
> The only protection against these pointers being accessed after
> the underlying data has been released by kfree() is by source
> code review of patches. Add a keyword line to the devicetree
> overlay maintainers entry to try to catch overlay notifier
> related patches.
>
> The keyword line is added to the devicetree overlay entry instead
> of the devicetree entry so that not all maintainers will receive
> the additional review traffic. Add Frank Rowand (already a
> maintainer in the devicetree entry) so that he will receive
> the additional review traffic.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
>
> changes from version 1:
> - removed extraneous "From:" tags at top of patch description
Applied, sorry it fell thru the cracks.
Rob