Change 'modifed' to 'modified'.
Change 'relys' to 'relays'.
Signed-off-by: Zhang Jiaming <[email protected]>
---
arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
index 1daa0c6b6f4e..82c51f015ea3 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
* support and should return the number of actual ports on the
* board.
*
- * This function must be modifed for every new Octeon board.
+ * This function must be modified for every new Octeon board.
* Internally it uses switch statements based on the cvmx_sysinfo
- * data to determine board types and revisions. It relys on the
+ * data to determine board types and revisions. It relays on the
* fact that every Octeon board receives a unique board type
* enumeration from the bootloader.
*
--
2.25.1
Hello!
On 6/22/22 12:07 PM, Zhang Jiaming wrote:
> Change 'modifed' to 'modified'.
> Change 'relys' to 'relays'.
I think it should be 'relies', not 'relays'.
> Signed-off-by: Zhang Jiaming <[email protected]>
> ---
> arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 1daa0c6b6f4e..82c51f015ea3 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
> * support and should return the number of actual ports on the
> * board.
> *
> - * This function must be modifed for every new Octeon board.
> + * This function must be modified for every new Octeon board.
> * Internally it uses switch statements based on the cvmx_sysinfo
> - * data to determine board types and revisions. It relys on the
> + * data to determine board types and revisions. It relays on the
> * fact that every Octeon board receives a unique board type
> * enumeration from the bootloader.
> *
MBR, Sergey
Change 'modifed' to 'modified'.
Change 'relys' to 'relies'.
Signed-off-by: Zhang Jiaming <[email protected]>
---
.../mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
arch/mips/include/asm/octeon/cvmx-helper-board.h | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
index 1daa0c6b6f4e..d09d0769f549 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
@@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
* support and should return the number of actual ports on the
* board.
*
- * This function must be modifed for every new Octeon board.
+ * This function must be modified for every new Octeon board.
* Internally it uses switch statements based on the cvmx_sysinfo
- * data to determine board types and revisions. It relys on the
+ * data to determine board types and revisions. It relies on the
* fact that every Octeon board receives a unique board type
* enumeration from the bootloader.
*
diff --git a/arch/mips/include/asm/octeon/cvmx-helper-board.h b/arch/mips/include/asm/octeon/cvmx-helper-board.h
index ce52aafe7a8d..cfe9c256a918 100644
--- a/arch/mips/include/asm/octeon/cvmx-helper-board.h
+++ b/arch/mips/include/asm/octeon/cvmx-helper-board.h
@@ -63,9 +63,9 @@ typedef enum {
* connected to this port. On chips supporting multiple MII
* busses the bus number is encoded in bits <15:8>.
*
- * This function must be modifed for every new Octeon board.
+ * This function must be modified for every new Octeon board.
* Internally it uses switch statements based on the cvmx_sysinfo
- * data to determine board types and revisions. It relys on the
+ * data to determine board types and revisions. It relies on the
* fact that every Octeon board receives a unique board type
* enumeration from the bootloader.
*
@@ -81,9 +81,9 @@ extern int cvmx_helper_board_get_mii_address(int ipd_port);
* and are handled by the fall through case. This function must be
* updated for boards that don't have the normal Marvell PHYs.
*
- * This function must be modifed for every new Octeon board.
+ * This function must be modified for every new Octeon board.
* Internally it uses switch statements based on the cvmx_sysinfo
- * data to determine board types and revisions. It relys on the
+ * data to determine board types and revisions. It relies on the
* fact that every Octeon board receives a unique board type
* enumeration from the bootloader.
*
@@ -103,9 +103,9 @@ extern union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port);
* support and should return the number of actual ports on the
* board.
*
- * This function must be modifed for every new Octeon board.
+ * This function must be modified for every new Octeon board.
* Internally it uses switch statements based on the cvmx_sysinfo
- * data to determine board types and revisions. It relys on the
+ * data to determine board types and revisions. It relies on the
* fact that every Octeon board receives a unique board type
* enumeration from the bootloader.
*
--
2.25.1
On Wed, 2022-06-22 at 07:28 -0700, Randy Dunlap wrote:
> On 6/22/22 02:07, Zhang Jiaming wrote:
> > Change 'modifed' to 'modified'.
> > Change 'relys' to 'relays'.
[]
> > diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[]
> > @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
> > * support and should return the number of actual ports on the
> > * board.
> > *
> > - * This function must be modifed for every new Octeon board.
> > + * This function must be modified for every new Octeon board.
> > * Internally it uses switch statements based on the cvmx_sysinfo
> > - * data to determine board types and revisions. It relys on the
>
> relies
>
> But it would be better to restrict this barrage (or swarm) of patches
> to Kconfig help text problems and/or strings that are printed to users.
I believe fixing typos isn't a particular problem and is
overall rather a good thing.
Though backporting these patches would be silly.
On 6/22/22 02:07, Zhang Jiaming wrote:
> Change 'modifed' to 'modified'.
> Change 'relys' to 'relays'.
>
> Signed-off-by: Zhang Jiaming <[email protected]>
> ---
> arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index 1daa0c6b6f4e..82c51f015ea3 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
> * support and should return the number of actual ports on the
> * board.
> *
> - * This function must be modifed for every new Octeon board.
> + * This function must be modified for every new Octeon board.
> * Internally it uses switch statements based on the cvmx_sysinfo
> - * data to determine board types and revisions. It relys on the
relies
But it would be better to restrict this barrage (or swarm) of patches
to Kconfig help text problems and/or strings that are printed to users.
> + * data to determine board types and revisions. It relays on the
> * fact that every Octeon board receives a unique board type
> * enumeration from the bootloader.
> *
--
~Randy
On 6/22/22 07:46, Joe Perches wrote:
> On Wed, 2022-06-22 at 07:28 -0700, Randy Dunlap wrote:
>> On 6/22/22 02:07, Zhang Jiaming wrote:
>>> Change 'modifed' to 'modified'.
>>> Change 'relys' to 'relays'.
> []
>>> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> []
>>> @@ -282,9 +282,9 @@ union cvmx_helper_link_info __cvmx_helper_board_link_get(int ipd_port)
>>> * support and should return the number of actual ports on the
>>> * board.
>>> *
>>> - * This function must be modifed for every new Octeon board.
>>> + * This function must be modified for every new Octeon board.
>>> * Internally it uses switch statements based on the cvmx_sysinfo
>>> - * data to determine board types and revisions. It relys on the
>>
>> relies
>>
>> But it would be better to restrict this barrage (or swarm) of patches
>> to Kconfig help text problems and/or strings that are printed to users.
>
> I believe fixing typos isn't a particular problem and is
> overall rather a good thing.
OK, I can agree with that.
> Though backporting these patches would be silly.
Ack.
--
~Randy
On Wed, Jun 22, 2022 at 06:27:20PM +0800, Zhang Jiaming wrote:
> Change 'modifed' to 'modified'.
> Change 'relys' to 'relies'.
>
> Signed-off-by: Zhang Jiaming <[email protected]>
> ---
> .../mips/cavium-octeon/executive/cvmx-helper-board.c | 4 ++--
> arch/mips/include/asm/octeon/cvmx-helper-board.h | 12 ++++++------
> 2 files changed, 8 insertions(+), 8 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]