2021-02-05 02:00:06

by Randy Dunlap

Subject: Re: [PATCH] lib: crc-itu-t: Fix comment in typo

On 2/4/21 4:47 PM, David Mosberger-Tang wrote:
> Signed-off-by: David Mosberger-Tang <[email protected]>
> ---
> lib/crc-itu-t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
> index 1974b355c148..56e6e0d63d1e 100644
> --- a/lib/crc-itu-t.c
> +++ b/lib/crc-itu-t.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include <linux/crc-itu-t.h>
>
> -/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
> +/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */

This comment should not be indicated as kernel-doc:
please use /* instead of /**.

> const u16 crc_itu_t_table[256] = {
> 0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
> 0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
>

thanks.
--
~Randy

2021-02-05 02:01:55

by David Mosberger-Tang

Subject: [PATCH] lib: crc-itu-t: Fix typo in comment

Signed-off-by: David Mosberger-Tang <[email protected]>
---
lib/crc-itu-t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index 1974b355c148..1d26a1647da5 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -7,7 +7,7 @@
#include <linux/module.h>
#include <linux/crc-itu-t.h>

-/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
+/* CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
const u16 crc_itu_t_table[256] = {
0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
--
2.25.1

2021-02-05 02:02:51

by Randy Dunlap

Subject: Re: [PATCH] lib: crc-itu-t: Fix typo in comment

On 2/4/21 5:02 PM, David Mosberger-Tang wrote:
> Signed-off-by: David Mosberger-Tang <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> lib/crc-itu-t.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
> index 1974b355c148..1d26a1647da5 100644
> --- a/lib/crc-itu-t.c
> +++ b/lib/crc-itu-t.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include <linux/crc-itu-t.h>
>
> -/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
> +/* CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
> const u16 crc_itu_t_table[256] = {
> 0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
> 0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
>


--
~Randy