2022-04-25 08:11:41

by baihaowen

Subject: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant

The function __perf_reg_mask has an unsigned return type, but returns a
negative constant to indicate an error condition. So we change unsigned
to int.

Signed-off-by: Haowen Bai <[email protected]>
---
tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
index fca054bbc094..c01a31d5f4ee 100644
--- a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
+++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
@@ -274,7 +274,7 @@ u64 *get_intr_regs(struct event *event, void *sample_buff)
return intr_regs;
}

-static const unsigned int __perf_reg_mask(const char *register_name)
+static const int __perf_reg_mask(const char *register_name)
{
if (!strcmp(register_name, "R0"))
return 0;
--
2.7.4

2022-04-26 15:51:31

by kajoljain

Subject: Re: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant

On 4/24/22 13:56, Haowen Bai wrote:
> The function __perf_reg_mask has an unsigned return type, but returns a
> negative constant to indicate an error condition. So we change unsigned
> to int.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
> index fca054bbc094..c01a31d5f4ee 100644
> --- a/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
> +++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c
> @@ -274,7 +274,7 @@ u64 *get_intr_regs(struct event *event, void *sample_buff)
> return intr_regs;
> }
>
> -static const unsigned int __perf_reg_mask(const char *register_name)
> +static const int __perf_reg_mask(const char *register_name)
> {

Hi Haowen,
Thanks for correcting it. Can you also add fix tag with corresponding
commit id details.

Other than that patch looks good to me.

Reviewed-by: Kajol Jain<[email protected]>

Thanks,
Kajol Jain


> if (!strcmp(register_name, "R0"))
> return 0;

2022-05-15 13:45:50

by Michael Ellerman

Subject: Re: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant

On Sun, 24 Apr 2022 16:26:41 +0800, Haowen Bai wrote:
> The function __perf_reg_mask has an unsigned return type, but returns a
> negative constant to indicate an error condition. So we change unsigned
> to int.
>
>

Applied to powerpc/next.

[1/1] selftests/powerpc/pmu: Fix unsigned function returning negative constant
https://git.kernel.org/powerpc/c/a84ca704d8306a949578d36c028c8e1bab3dcf0b

cheers