2018-12-12 09:25:50

by Yue Haibing

[permalink] [raw]
Subject: [PATCH net-next] can: flexcan: fix 'passing zero to ERR_PTR()' warning

Fix a static code checker warning:
drivers/net/can/flexcan.c:1435 flexcan_setup_stop_mode() warn: passing zero to 'PTR_ERR'

Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/can/flexcan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 0f36eaf..5f09764 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -1432,7 +1432,7 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
gpr_np = of_find_node_by_phandle(phandle);
if (!gpr_np) {
dev_dbg(&pdev->dev, "could not find gpr node by phandle\n");
- return PTR_ERR(gpr_np);
+ return -ENODEV;
}

priv = netdev_priv(dev);
--
2.7.0




2019-01-04 17:25:21

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH net-next] can: flexcan: fix 'passing zero to ERR_PTR()' warning

On 12/12/18 10:24 AM, YueHaibing wrote:
> Fix a static code checker warning:
> drivers/net/can/flexcan.c:1435 flexcan_setup_stop_mode() warn: passing zero to 'PTR_ERR'
>
> Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
> Signed-off-by: YueHaibing <[email protected]>

Applied to linux-can.

tnx,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |


Attachments:
signature.asc (499.00 B)
OpenPGP digital signature