2018-02-11 21:05:30

by SF Markus Elfring

Subject: [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 11 Feb 2018 21:56:42 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpio/gpio-intel-mid.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index 629575ea46a0..028d64c2cb1e 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -361,10 +361,8 @@ static int intel_gpio_probe(struct pci_dev *pdev,
pcim_iounmap_regions(pdev, 1 << 1);

priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "can't allocate chip data\n");
+ if (!priv)
return -ENOMEM;
- }

priv->reg_base = pcim_iomap_table(pdev)[0];
priv->chip.label = dev_name(&pdev->dev);
--
2.16.1

2018-02-13 18:46:59

by Andy Shevchenko

Subject: Re: [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()

On Sun, Feb 11, 2018 at 11:04 PM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Sun, 11 Feb 2018 21:56:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>

Linus, same comment as previously.
If you are OK with the change, take my

Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/gpio/gpio-intel-mid.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
> index 629575ea46a0..028d64c2cb1e 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -361,10 +361,8 @@ static int intel_gpio_probe(struct pci_dev *pdev,
> pcim_iounmap_regions(pdev, 1 << 1);
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - dev_err(&pdev->dev, "can't allocate chip data\n");
> + if (!priv)
> return -ENOMEM;
> - }
>
> priv->reg_base = pcim_iomap_table(pdev)[0];
> priv->chip.label = dev_name(&pdev->dev);
> --
> 2.16.1
>



--
With Best Regards,
Andy Shevchenko

2018-02-22 14:31:32

by Linus Walleij

Subject: Re: [PATCH] gpio-intel-mid: Delete an error message for a failed memory allocation in intel_gpio_probe()

On Sun, Feb 11, 2018 at 10:04 PM, SF Markus Elfring
<[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Sun, 11 Feb 2018 21:56:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch applied.

Yours,
Linus Walleij