2023-12-20 23:14:38

by Jacob Keller

[permalink] [raw]
Subject: Re: [PATCH V2 01/12 net-next] qca_spi: Improve SPI thread creation



On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> The qca_spi driver create/stop the SPI kernel thread in case
> of netdev_open/close. This isn't optimal because there is no
> need for such an expensive operation.
>
> So improve this by moving create/stop of the SPI kernel into
> the init/uninit ops. The open/close ops could just
> 'park/unpark' the SPI kernel thread.
>

If I understand, this is also important because kthread_stop would
ultimately result in the task being destroyed and thus user space
configuration of the task (priority, pinning, etc) would be lost too.

Reviewed-by: Jacob Keller <[email protected]>