2017-06-09 06:10:20

by Arvind Yadav

Subject: [PATCH] ALSA : pcsp: pcsp_lib: constify snd_pcsp_playback_ops

File size before:
text data bss dec hex filename
2027 168 1 2196 894 sound/drivers/pcsp/pcsp_lib.o

File size After:
text data bss dec hex filename
2155 40 1 2196 894 sound/drivers/pcsp/pcsp_lib.o

Signed-off-by: Arvind Yadav <[email protected]>
---
sound/drivers/pcsp/pcsp_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/drivers/pcsp/pcsp_lib.c b/sound/drivers/pcsp/pcsp_lib.c
index aca2d7d..44b3632 100644
--- a/sound/drivers/pcsp/pcsp_lib.c
+++ b/sound/drivers/pcsp/pcsp_lib.c
@@ -323,7 +323,7 @@ static int snd_pcsp_playback_open(struct snd_pcm_substream *substream)
return 0;
}

-static struct snd_pcm_ops snd_pcsp_playback_ops = {
+static const struct snd_pcm_ops snd_pcsp_playback_ops = {
.open = snd_pcsp_playback_open,
.close = snd_pcsp_playback_close,
.ioctl = snd_pcm_lib_ioctl,
--
1.9.1

2017-06-09 07:20:11

by Takashi Iwai

Subject: Re: [PATCH] ALSA : pcsp: pcsp_lib: constify snd_pcsp_playback_ops

On Fri, 09 Jun 2017 08:09:56 +0200,
Arvind Yadav wrote:
>
> File size before:
> text data bss dec hex filename
> 2027 168 1 2196 894 sound/drivers/pcsp/pcsp_lib.o
>
> File size After:
> text data bss dec hex filename
> 2155 40 1 2196 894 sound/drivers/pcsp/pcsp_lib.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied, thanks.


Takashi


> ---
> sound/drivers/pcsp/pcsp_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/drivers/pcsp/pcsp_lib.c b/sound/drivers/pcsp/pcsp_lib.c
> index aca2d7d..44b3632 100644
> --- a/sound/drivers/pcsp/pcsp_lib.c
> +++ b/sound/drivers/pcsp/pcsp_lib.c
> @@ -323,7 +323,7 @@ static int snd_pcsp_playback_open(struct snd_pcm_substream *substream)
> return 0;
> }
>
> -static struct snd_pcm_ops snd_pcsp_playback_ops = {
> +static const struct snd_pcm_ops snd_pcsp_playback_ops = {
> .open = snd_pcsp_playback_open,
> .close = snd_pcsp_playback_close,
> .ioctl = snd_pcm_lib_ioctl,
> --
> 1.9.1
>
>