2022-05-25 19:47:25

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 1/4] sh: Kconfig: Fix indentation

The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.

While at it, remove stray spaces from seemingly empty lines.

Signed-off-by: Juerg Haefliger <[email protected]>
---
arch/sh/Kconfig | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 5f220e903e5a..fc15fd6b719e 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -200,9 +200,9 @@ config ARCH_SHMOBILE
select PM

config CPU_HAS_PMU
- depends on CPU_SH4 || CPU_SH4A
- default y
- bool
+ depends on CPU_SH4 || CPU_SH4A
+ default y
+ bool

choice
prompt "Processor sub-type selection"
@@ -231,7 +231,7 @@ config CPU_SUBTYPE_SH7201
select CPU_SH2A
select CPU_HAS_FPU
select SYS_SUPPORTS_SH_MTU2
-
+
config CPU_SUBTYPE_SH7203
bool "Support SH7203 processor"
select CPU_SH2A
@@ -493,7 +493,7 @@ config CPU_SUBTYPE_SH7366
endchoice

source "arch/sh/mm/Kconfig"
-
+
source "arch/sh/Kconfig.cpu"

source "arch/sh/boards/Kconfig"
@@ -644,7 +644,7 @@ config GUSA
This is the default implementation for both UP and non-ll/sc
CPUs, and is used by the libc, amongst others.

- For additional information, design information can be found
+ For additional information, design information can be found
in <http://lc.linux.or.jp/lc2002/papers/niibe0919p.pdf>.

This should only be disabled for special cases where alternate
@@ -775,12 +775,12 @@ config MAPLE
bool "Maple Bus support"
depends on SH_DREAMCAST
help
- The Maple Bus is SEGA's serial communication bus for peripherals
- on the Dreamcast. Without this bus support you won't be able to
- get your Dreamcast keyboard etc to work, so most users
- probably want to say 'Y' here, unless you are only using the
- Dreamcast with a serial line terminal or a remote network
- connection.
+ The Maple Bus is SEGA's serial communication bus for peripherals
+ on the Dreamcast. Without this bus support you won't be able to
+ get your Dreamcast keyboard etc to work, so most users
+ probably want to say 'Y' here, unless you are only using the
+ Dreamcast with a serial line terminal or a remote network
+ connection.

endmenu

--
2.32.0



2022-05-26 20:47:05

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [PATCH 1/4] sh: Kconfig: Fix indentation

On 5/25/22 3:40 PM, Juerg Haefliger wrote:

> The convention for indentation seems to be a single tab. Help text is
> further indented by an additional two whitespaces. Fix the lines that
> violate these rules.
>
> While at it, remove stray spaces from seemingly empty lines.

You're also fixing some trailing spaces... that all counts up
to fixing trailing whitespace.

> Signed-off-by: Juerg Haefliger <[email protected]>
> ---
> arch/sh/Kconfig | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 5f220e903e5a..fc15fd6b719e 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
[...]
> @@ -644,7 +644,7 @@ config GUSA
> This is the default implementation for both UP and non-ll/sc
> CPUs, and is used by the libc, amongst others.
>
> - For additional information, design information can be found
> + For additional information, design information can be found
> in <http://lc.linux.or.jp/lc2002/papers/niibe0919p.pdf>.
>
> This should only be disabled for special cases where alternate
[...]

MBR, Sergey

2022-05-28 18:54:41

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 1/4 v2] sh: Kconfig: Fix indentation and remove trailing whitespaces

The convention for indentation seems to be a single tab. Help text is
further indented by an additional two spaces. Fix the lines that violate
these rules.

While at it, remove trailing whitespaces.

Signed-off-by: Juerg Haefliger <[email protected]>
---
v2:
Update commit message and subject per review comments.
---
arch/sh/Kconfig | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 5f220e903e5a..fc15fd6b719e 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -200,9 +200,9 @@ config ARCH_SHMOBILE
select PM

config CPU_HAS_PMU
- depends on CPU_SH4 || CPU_SH4A
- default y
- bool
+ depends on CPU_SH4 || CPU_SH4A
+ default y
+ bool

choice
prompt "Processor sub-type selection"
@@ -231,7 +231,7 @@ config CPU_SUBTYPE_SH7201
select CPU_SH2A
select CPU_HAS_FPU
select SYS_SUPPORTS_SH_MTU2
-
+
config CPU_SUBTYPE_SH7203
bool "Support SH7203 processor"
select CPU_SH2A
@@ -493,7 +493,7 @@ config CPU_SUBTYPE_SH7366
endchoice

source "arch/sh/mm/Kconfig"
-
+
source "arch/sh/Kconfig.cpu"

source "arch/sh/boards/Kconfig"
@@ -644,7 +644,7 @@ config GUSA
This is the default implementation for both UP and non-ll/sc
CPUs, and is used by the libc, amongst others.

- For additional information, design information can be found
+ For additional information, design information can be found
in <http://lc.linux.or.jp/lc2002/papers/niibe0919p.pdf>.

This should only be disabled for special cases where alternate
@@ -775,12 +775,12 @@ config MAPLE
bool "Maple Bus support"
depends on SH_DREAMCAST
help
- The Maple Bus is SEGA's serial communication bus for peripherals
- on the Dreamcast. Without this bus support you won't be able to
- get your Dreamcast keyboard etc to work, so most users
- probably want to say 'Y' here, unless you are only using the
- Dreamcast with a serial line terminal or a remote network
- connection.
+ The Maple Bus is SEGA's serial communication bus for peripherals
+ on the Dreamcast. Without this bus support you won't be able to
+ get your Dreamcast keyboard etc to work, so most users
+ probably want to say 'Y' here, unless you are only using the
+ Dreamcast with a serial line terminal or a remote network
+ connection.

endmenu

--
2.32.0