Hi all,
Today's linux-next merge of the vfio tree got a conflict in:
include/linux/vfio_pci_core.h
between commits:
b6a7066f4e9b ("vfio/pci: introduce CONFIG_VFIO_PCI_ZDEV_KVM")
6518ebc68c72 ("vfio-pci/zdev: add open/close device hooks")
from the kvms390 tree and commit:
d1877e639bc6 ("vfio: de-extern-ify function prototypes")
from the vfio tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc include/linux/vfio_pci_core.h
index d5d9e17f0156,22de2bce6394..000000000000
--- a/include/linux/vfio_pci_core.h
+++ b/include/linux/vfio_pci_core.h
@@@ -206,11 -205,9 +205,11 @@@ static inline int vfio_pci_igd_init(str
}
#endif
-#ifdef CONFIG_S390
+#ifdef CONFIG_VFIO_PCI_ZDEV_KVM
- extern int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,
- struct vfio_info_cap *caps);
+ int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,
+ struct vfio_info_cap *caps);
+int vfio_pci_zdev_open_device(struct vfio_pci_core_device *vdev);
+void vfio_pci_zdev_close_device(struct vfio_pci_core_device *vdev);
#else
static inline int vfio_pci_info_zdev_add_caps(struct vfio_pci_core_device *vdev,
struct vfio_info_cap *caps)
Am 11.07.22 um 09:13 schrieb Stephen Rothwell:
> Betreff:
> linux-next: manual merge of the vfio tree with the kvms390 tree
> Von:
> Stephen Rothwell <[email protected]>
> Datum:
> 11.07.22, 09:13
>
> An:
> Alex Williamson <[email protected]>, Christian Borntraeger <[email protected]>, Janosch Frank <[email protected]>
> Kopie (CC):
> Linux Kernel Mailing List <[email protected]>, Linux Next Mailing List <[email protected]>, Matthew Rosato <[email protected]>
>
>
> Hi all,
>
> Today's linux-next merge of the vfio tree got a conflict in:
>
> include/linux/vfio_pci_core.h
>
> between commits:
>
> b6a7066f4e9b ("vfio/pci: introduce CONFIG_VFIO_PCI_ZDEV_KVM")
> 6518ebc68c72 ("vfio-pci/zdev: add open/close device hooks")
>
> from the kvms390 tree and commit:
>
> d1877e639bc6 ("vfio: de-extern-ify function prototypes")
>
> from the vfio tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
Alex, Paolo,
I do have a topic branch that we could merge, but I think the conflict is trivial enough for the time being.